Skip to content

WasmBuildTest can exit with negative code#108181

Merged
ilonatommy merged 1 commit into
dotnet:mainfrom
ilonatommy:exit-code-can-be-negative
Sep 25, 2024
Merged

WasmBuildTest can exit with negative code#108181
ilonatommy merged 1 commit into
dotnet:mainfrom
ilonatommy:exit-code-can-be-negative

Conversation

@ilonatommy

@ilonatommy ilonatommy commented Sep 24, 2024

Copy link
Copy Markdown
Member

Before the change:

Error: incorrect localized value for Sunday in locale zh-CN. Expected 'nedeľa' but got 'Sunday'.
WASM EXIT -1
Exception: System.Exception: Timed out after 120s waiting for 'WASM EXIT' message
     at Wasm.Build.Tests.BrowserRunner.WaitForExitMessageAsync(TimeSpan timeout) in /workspaces/runtime/src/mono/wasm/Wasm.Build.Tests/BrowserRunner.cs:line 211
     at Wasm.Build.Tests.WasmTemplateTestsBase.RunBrowser(String config, String projectFile, String language) in /workspaces/runtime/src/mono/wasm/Wasm.Build.Tests/Templates/WasmTemplateTestsBase.cs:line 119
     at Wasm.Build.Tests.WasmTemplateTestsBase.RunBrowser(String config, String projectFile, String language) in /workspaces/runtime/src/mono/wasm/Wasm.Build.Tests/Templates/WasmTemplateTestsBase.cs:line 120
     at Wasm.Build.Tests.IcuTestsBase.BuildAndRunIcuTest(String config, String templateType, Boolean aot, String testedLocales, GlobalizationMode globalizationMode, String extraProperties, Boolean onlyPredefinedCultures, String language, String icuFileName) in /workspaces/runtime/src/mono/wasm/Wasm.Build.Tests/IcuTestsBase.cs:line 180; _testOutput=[] Executing (Captured Output) - /workspaces/runtime/artifacts/bin/dotnet-latest/dotnet new wasmbrowser  -  in pwd /workspaces/runtime/artifacts/bin/Wasm.Build.Tests/Release/net9.0/linux-x64/wbt artifacts/icu_Release_False_0zfc3ohv_13h

After:
Just failure with -1, no timeout exception.

@ilonatommy ilonatommy self-assigned this Sep 24, 2024
@ilonatommy ilonatommy requested a review from maraf as a code owner September 24, 2024 12:08
@ghost ghost added the area-Build-mono label Sep 24, 2024
@ilonatommy ilonatommy added this to the 10.0.0 milestone Sep 24, 2024
@ilonatommy ilonatommy added the arch-wasm WebAssembly architecture label Sep 24, 2024
@dotnet-policy-service

Copy link
Copy Markdown
Contributor

Tagging subscribers to 'arch-wasm': @lewing
See info in area-owners.md if you want to be subscribed.

@ilonatommy ilonatommy added the os-browser Browser variant of arch-wasm label Sep 24, 2024
@ilonatommy ilonatommy merged commit 080fcae into dotnet:main Sep 25, 2024
sirntar pushed a commit to sirntar/runtime that referenced this pull request Sep 30, 2024
@github-actions github-actions Bot locked and limited conversation to collaborators Oct 25, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

arch-wasm WebAssembly architecture area-Build-mono os-browser Browser variant of arch-wasm

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants