-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[cdac] break up cdacreader into 4 separate assemblies #108156
Merged
Merged
Commits on Sep 23, 2024
-
[cdac] break up cdacreader into 4 separate assemblies
Break up the monolithic cdacreader assembly into three parts: 1. `Microsoft.Diagnostics.DataContractReader.Abstractions` just the API surface for contract implementations and clients **note** everything is `internal` for now (with IVT for the other assemblies) - we're not committing to a public API surface yet 2. `Microsoft.Diagnostics.DataContractReader.Contracts`: the concrete implementations of the contracts and data 3. `Microsoft.Diagnostics.DataCotnractReader`: a concrete `Target` that ties everything together 4. `cdacreader` just the unmanaged entrypoints and the legacy DAC API surface `SOSDacImpl` To untangle things I had to add a new `IContractFactory<TProduct>` interface - this is what the target's `Registry` uses to instantiate specific versions of contracts. Goals: 1. Make it possible to mock a `ITarget` and its `IRegistry` so that concrete contracts can be tested in isolation for example by making dummy dependent contracts that return canned answers. 2. Eventually make it possible to inject additional contract implementations into a `Registry` implementations 3. Make it possible to consume just the `Target` and `Contracts` without the unmanaged entrypoints or the legacy interfaces
Configuration menu - View commit details
-
Copy full SHA for 089dfe2 - Browse repository at this point
Copy the full SHA 089dfe2View commit details
Commits on Sep 24, 2024
-
Configuration menu - View commit details
-
Copy full SHA for c283b13 - Browse repository at this point
Copy the full SHA c283b13View commit details -
Configuration menu - View commit details
-
Copy full SHA for cc3a4f1 - Browse repository at this point
Copy the full SHA cc3a4f1View commit details -
Configuration menu - View commit details
-
Copy full SHA for 4a5cd7a - Browse repository at this point
Copy the full SHA 4a5cd7aView commit details -
Configuration menu - View commit details
-
Copy full SHA for 18e9d00 - Browse repository at this point
Copy the full SHA 18e9d00View commit details -
Configuration menu - View commit details
-
Copy full SHA for ba9d83a - Browse repository at this point
Copy the full SHA ba9d83aView commit details
Commits on Sep 25, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 87d026a - Browse repository at this point
Copy the full SHA 87d026aView commit details -
Configuration menu - View commit details
-
Copy full SHA for 0f2130d - Browse repository at this point
Copy the full SHA 0f2130dView commit details -
Configuration menu - View commit details
-
Copy full SHA for 9b937bc - Browse repository at this point
Copy the full SHA 9b937bcView commit details -
Configuration menu - View commit details
-
Copy full SHA for fd83148 - Browse repository at this point
Copy the full SHA fd83148View commit details -
Add ReadTargetPointerFromSpan to abstract Target
Allows the TypeNameBuidler and SigFormat to depend on the abstract target
Configuration menu - View commit details
-
Copy full SHA for 6a45fba - Browse repository at this point
Copy the full SHA 6a45fbaView commit details -
Configuration menu - View commit details
-
Copy full SHA for bd64632 - Browse repository at this point
Copy the full SHA bd64632View commit details -
Configuration menu - View commit details
-
Copy full SHA for ff762e0 - Browse repository at this point
Copy the full SHA ff762e0View commit details -
rename ContractRegistry -> CachingContractRegistry; AbstractContractR…
…egistry -> ContractRegistry
Configuration menu - View commit details
-
Copy full SHA for 75dfc46 - Browse repository at this point
Copy the full SHA 75dfc46View commit details -
Configuration menu - View commit details
-
Copy full SHA for 15ef960 - Browse repository at this point
Copy the full SHA 15ef960View commit details
Commits on Sep 26, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 1ad195b - Browse repository at this point
Copy the full SHA 1ad195bView commit details -
Configuration menu - View commit details
-
Copy full SHA for f0700c2 - Browse repository at this point
Copy the full SHA f0700c2View commit details
Commits on Sep 27, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 32d956b - Browse repository at this point
Copy the full SHA 32d956bView commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.