Ensure we create new RemoteInvokeOptions for every call #107820
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The RemoteInvokeOptions instance is mutated by RemoveExecutor.Invoke and cannot be shared.
ericstj
requested review from
kunalspathak,
mikelle-rogers,
buyaa-n and
stephentoub
hoyosjs
approved these changes
Sep 14, 2024
stephentoub
approved these changes
Sep 14, 2024
|
/backport to release/9.0 |
|
Started backporting to release/9.0: https://github.com/dotnet/runtime/actions/runs/10886995195 |
Merged
4 tasks
|
@ericstj - wondering what changed that these tests started to fail recently? |
|
I don't have any hard data that shows a recent uptick in occurrences. All the recent traffic was due to manual analysis on JITStress and PGO legs. I agree that's increased - but that just could be coincident with the push to try and get these green by release. We never saw this failing in the actual monitored build legs. Either they don't run with elevated permissions to install services - or they run on machines with fewer cores and don't actually run these tests concurrently. |
jtschuster
pushed a commit
to jtschuster/runtime
that referenced
this pull request
Sep 17, 2024
The RemoteInvokeOptions instance is mutated by RemoveExecutor.Invoke and cannot be shared.
sirntar
pushed a commit
to sirntar/runtime
that referenced
this pull request
Sep 30, 2024
The RemoteInvokeOptions instance is mutated by RemoveExecutor.Invoke and cannot be shared.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #107671, #107240
The
RemoteInvokeOptionsinstance is mutated byRemoveExecutor.Invokeand cannot be shared.