Skip to content

Remove DebuggerModule::Get/SetPrimaryModule - always itself #107767

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 13, 2024

Conversation

elinor-fung
Copy link
Member

This looks to be from multi-app domain / shared domain support. DebuggerModule::SetPrimaryModule is never called anymore - the 'primary' module is always itself.

cc @jkotas @AaronRobinsonMSFT

@elinor-fung elinor-fung requested a review from a team September 12, 2024 21:25
@elinor-fung elinor-fung merged commit 5ca3f79 into dotnet:main Sep 13, 2024
84 of 88 checks passed
@elinor-fung elinor-fung deleted the remove-primary-module branch September 13, 2024 00:49
jtschuster pushed a commit to jtschuster/runtime that referenced this pull request Sep 17, 2024
sirntar pushed a commit to sirntar/runtime that referenced this pull request Sep 30, 2024
@github-actions github-actions bot locked and limited conversation to collaborators Oct 13, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants