[release/9.0] Fix config source gen binding with SslClientAuthenticationOptions#107705
Merged
artl93 merged 2 commits intorelease/9.0from Sep 11, 2024
Merged
[release/9.0] Fix config source gen binding with SslClientAuthenticationOptions#107705artl93 merged 2 commits intorelease/9.0from
artl93 merged 2 commits intorelease/9.0from
Conversation
Co-authored-by: Eric Erhardt <eric.erhardt@microsoft.com>
Contributor
|
Tagging subscribers to this area: @dotnet/area-extensions-configuration |
Member
artl93
approved these changes
Sep 11, 2024
Member
|
/ba-g no real failure there. Ci just skipped one leg analysis. |
Member
|
Merging per comment above after discussing. |
This was referenced Sep 12, 2024
Open
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of #107579 to release/9.0
/cc @tarekgh
Customer Impact
[Select one or both of the boxes. Describe how this issue impacts customers, citing the expected and actual behaviors and scope of the issue. If customer-reported, provide the issue number.]
When using configuration in the Aspire dashboard, the source generator may produce uncompilable code, leading to compilation errors. This occurs because the source generator wasn't correctly handling certain types (e.g.,
SslClientAuthenticationOptions) that have properties with unbindable types, yet it still generates code attempting to initialize bindings for them.Regression
[If yes, specify when the regression was introduced. Provide the PR or commit if known.]
Testing
The regression tests have passed, and additional tests were added to cover the previously broken cases.
[How was the fix verified? How was the issue missed previously? What tests were added?]
Risk
Not high as the fix is scoped to the broken case.
[High/Medium/Low. Justify the indication by mentioning how risks were measured and addressed.]
IMPORTANT: If this backport is for a servicing release, please verify that:
The PR target branch is
release/X.0-staging, notrelease/X.0.If the change touches code that ships in a NuGet package, you have added the necessary package authoring and gotten it explicitly reviewed.