Skip to content

[release/9.0] Fix config source gen binding with SslClientAuthenticationOptions#107705

Merged
artl93 merged 2 commits intorelease/9.0from
backport/pr-107579-to-release/9.0
Sep 11, 2024
Merged

[release/9.0] Fix config source gen binding with SslClientAuthenticationOptions#107705
artl93 merged 2 commits intorelease/9.0from
backport/pr-107579-to-release/9.0

Conversation

@github-actions
Copy link
Copy Markdown
Contributor

@github-actions github-actions bot commented Sep 11, 2024

Backport of #107579 to release/9.0

/cc @tarekgh

Customer Impact

[Select one or both of the boxes. Describe how this issue impacts customers, citing the expected and actual behaviors and scope of the issue. If customer-reported, provide the issue number.]

When using configuration in the Aspire dashboard, the source generator may produce uncompilable code, leading to compilation errors. This occurs because the source generator wasn't correctly handling certain types (e.g., SslClientAuthenticationOptions) that have properties with unbindable types, yet it still generates code attempting to initialize bindings for them.

Regression

  • Yes
  • No

[If yes, specify when the regression was introduced. Provide the PR or commit if known.]

Testing

The regression tests have passed, and additional tests were added to cover the previously broken cases.

[How was the fix verified? How was the issue missed previously? What tests were added?]

Risk

Not high as the fix is scoped to the broken case.

[High/Medium/Low. Justify the indication by mentioning how risks were measured and addressed.]

IMPORTANT: If this backport is for a servicing release, please verify that:

  • The PR target branch is release/X.0-staging, not release/X.0.

  • If the change touches code that ships in a NuGet package, you have added the necessary package authoring and gotten it explicitly reviewed.

@dotnet-policy-service
Copy link
Copy Markdown
Contributor

Tagging subscribers to this area: @dotnet/area-extensions-configuration
See info in area-owners.md if you want to be subscribed.

@tarekgh tarekgh added this to the 9.0.0 milestone Sep 11, 2024
@tarekgh tarekgh added Servicing-consider Issue for next servicing release review source-generator Indicates an issue with a source generator feature labels Sep 11, 2024
@tarekgh
Copy link
Copy Markdown
Member

tarekgh commented Sep 11, 2024

CC @artl93 @ericstj

@artl93 artl93 added Servicing-approved Approved for servicing release and removed Servicing-consider Issue for next servicing release review labels Sep 11, 2024
@tarekgh
Copy link
Copy Markdown
Member

tarekgh commented Sep 11, 2024

/ba-g no real failure there. Ci just skipped one leg analysis.

@artl93
Copy link
Copy Markdown
Member

artl93 commented Sep 11, 2024

Merging per comment above after discussing.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

area-Extensions-Configuration Servicing-approved Approved for servicing release source-generator Indicates an issue with a source generator feature

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants