[release/9.0] Add the _requiresAlign8 bool to the compare and mangled name for GCStaticEETypeNode.cs#107701
Merged
jkotas merged 1 commit intorelease/9.0from Sep 11, 2024
Merged
Conversation
github-actions
bot
requested a review
from MichalStrehovsky
as a code owner
ghost
added
the
Contributor
|
Tagging subscribers to this area: @agocke, @MichalStrehovsky, @jkotas |
jeffschwMSFT
approved these changes
Sep 11, 2024
Member
jeffschwMSFT
left a comment
jeffschwMSFT
left a comment
There was a problem hiding this comment.
approved. please get a code review and we can merge when ready
MichalStrehovsky
approved these changes
Sep 11, 2024
Member
|
Failure is known issue #106742 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of #107650 to release/9.0
/cc @jkotas @yowl
Customer Impact
Application that contains thread statics that require 8-byte alignment (long, double) may crash on Linux Arm32 when compiled with native AOT.
Regression
This a bug in Arm32 support for native AOT that is new in .NET 9.
Testing
Found and verified in Avalona app targeting wasm in runtimelab. Wasm has similar alignment requirements as Arm32.
Risk
[High/Medium/Low. Justify the indication by mentioning how risks were measured and addressed.]
IMPORTANT: If this backport is for a servicing release, please verify that:
The PR target branch is
release/X.0-staging, notrelease/X.0.If the change touches code that ships in a NuGet package, you have added the necessary package authoring and gotten it explicitly reviewed.