Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WebSocket Feedback Follow-up #107662

Merged
merged 9 commits into from
Sep 18, 2024
Merged

WebSocket Feedback Follow-up #107662

merged 9 commits into from
Sep 18, 2024

Conversation

CarnaViire
Copy link
Member

Addressing remaining PR feedback from #105841

cc @MihaZupan @stephentoub

Copy link
Contributor

Tagging subscribers to this area: @dotnet/ncl
See info in area-owners.md if you want to be subscribed.

@CarnaViire
Copy link
Member Author

The only thing I didn't address was UnsafeOnCompleted because I feel like there's more things that are not quite right/expected with activities here, so quick investigation wasn't enough for me to find out what it is and whether it's just my own lack of knowledge. So I decided to address it separately. (cc @MihaZupan)

…WebSocketStateHelper.cs

Co-authored-by: Miha Zupan <mihazupan.zupan1@gmail.com>
@CarnaViire
Copy link
Member Author

runtime-dev-innerloop hang is dotnet/dnceng#3879

@CarnaViire CarnaViire merged commit b6b0fb1 into dotnet:main Sep 18, 2024
81 of 85 checks passed
sirntar pushed a commit to sirntar/runtime that referenced this pull request Sep 30, 2024
* Fixes

* State validation update

* Roll back dispose changes, fix mutex logging

* Roll back observe changes

* Add internal flags enum for states

* Update src/libraries/System.Net.WebSockets/src/System/Net/WebSockets/WebSocketStateHelper.cs

Co-authored-by: Miha Zupan <mihazupan.zupan1@gmail.com>

* Feedback

---------

Co-authored-by: Miha Zupan <mihazupan.zupan1@gmail.com>
@github-actions github-actions bot locked and limited conversation to collaborators Oct 19, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants