Skip to content

[release/9.0] JIT: don't create vector constants from relocatable constants #107500

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jeffschwMSFT merged 3 commits into from
Sep 11, 2024
Merged

[release/9.0] JIT: don't create vector constants from relocatable constants #107500

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
4af5ec1
JIT: don't create vector constants from relocatable constants
AndyAyersMS Sep 6, 2024
b1b9713
Merge branch 'release/9.0' into backport/pr-107491-to-release/9.0
jeffschwMSFT Sep 11, 2024
c51beac
Merge branch 'release/9.0' into backport/pr-107491-to-release/9.0
jeffschwMSFT Sep 11, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 11 additions & 1 deletion src/coreclr/jit/lower.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8823,12 +8823,22 @@ void Lowering::LowerStoreIndirCoalescing(GenTreeIndir* ind)
assert(prevData.IsStore());
assert(currData.IsStore());

// For now, only constants are supported for data.
// For now, only non-relocatable constants are supported for data.
if (!prevData.value->OperIsConst() || !currData.value->OperIsConst())
{
return;
}

if (prevData.value->IsCnsIntOrI() && prevData.value->AsIntCon()->ImmedValNeedsReloc(comp))
{
return;
}

if (currData.value->IsCnsIntOrI() && currData.value->AsIntCon()->ImmedValNeedsReloc(comp))
{
return;
}

// Otherwise, the difference between two offsets has to match the size of the type.
// We don't support overlapping stores.
if (abs(prevData.offset - currData.offset) != (int)genTypeSize(prevData.targetType))
Expand Down