Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Track that kmov instructions may write to GPR register #107428

Merged
merged 3 commits into from
Sep 6, 2024

Conversation

kunalspathak
Copy link
Member

There were several kmov* instructions missing from method emitInsCanOnlyWriteSSE2OrAVXReg.

Closes: #106545

@dotnet-issue-labeler dotnet-issue-labeler bot added the area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI label Sep 5, 2024
@kunalspathak
Copy link
Member Author

@dotnet/jit-contrib

Copy link
Member

@BruceForstall BruceForstall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kunalspathak
Copy link
Member Author

/ba-g failure seems flaky and unrelated

@kunalspathak kunalspathak merged commit 3b04bbe into dotnet:main Sep 6, 2024
119 of 121 checks passed
@kunalspathak kunalspathak deleted the issue_106545 branch September 6, 2024 03:56
@kunalspathak
Copy link
Member Author

/backport to release/9.0

Copy link
Contributor

github-actions bot commented Sep 6, 2024

Started backporting to release/9.0: https://github.com/dotnet/runtime/actions/runs/10742618880

jtschuster pushed a commit to jtschuster/runtime that referenced this pull request Sep 17, 2024
* kmov*_gpr writes to gpr

* add test

* Add using
sirntar pushed a commit to sirntar/runtime that referenced this pull request Sep 30, 2024
* kmov*_gpr writes to gpr

* add test

* Add using
@github-actions github-actions bot locked and limited conversation to collaborators Oct 7, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

JIT: Assertion failed '(emitThisGCrefRegs & regMask) == 0' during 'Emit code'
2 participants