Minor changes to make it easier to sync diagnostic repo copy #107066
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
|
Tagging subscribers to this area: @mangod9 |
hoyosjs
approved these changes
Aug 28, 2024
jkotas
reviewed
Aug 28, 2024
3 tasks
Open
3 tasks
am11
reviewed
Aug 28, 2024
| @@ -2093,7 +2095,7 @@ void GcInfoDecoder::ReportRegisterToGC( | |||
| LOG((LF_GCROOTS, LL_INFO1000, "Reporting " FMT_REG, regNum )); | |||
|
|
|||
| OBJECTREF* pObjRef = GetRegisterSlot( regNum, pRD ); | |||
| #if defined(TARGET_UNIX) && !defined(FEATURE_NATIVEAOT) && !defined(SOS_TARGET_AMD64) | |||
| #if defined(TARGET_UNIX) && !defined(FEATURE_NATIVEAOT) && !defined(SOS_TARGET_RISCV64) | |||
There was a problem hiding this comment.
Was replacing ARM64 with RISCV64 intentional or do we need both?
There was a problem hiding this comment.
Yes, they were incorrect and caused build problems in the diagnostic repo. This section of code is under ifdef TARGET_RISCV64.
am11
reviewed
Aug 28, 2024
| @@ -1976,7 +1978,7 @@ void GcInfoDecoder::ReportRegisterToGC( | |||
|
|
|||
| gcFlags |= GC_CALL_PINNED; | |||
| } | |||
| #endif // TARGET_UNIX && !SOS_TARGET_ARM64 | |||
| #endif // TARGET_UNIX && !SOS_TARGET_LOONGARCH64 | |||
There was a problem hiding this comment.
Also here, should we keep both conditions?
There was a problem hiding this comment.
Yes, they were incorrect and caused build problems in the diagnostic repo. This section of code is under ifdef TARGET_LOONGARCH64.
jtschuster
pushed a commit
to jtschuster/runtime
that referenced
this pull request
Sep 17, 2024
…107066) * Minor changes to make it easier to sync diagnostic repo copy * Undo ELF.h changes.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.