Ensure that Vector128.CreateSequence works on x86 for non-constant 64-bit inputs#107053
Merged
tannergooding merged 2 commits intodotnet:mainfrom Aug 29, 2024
Merged
Ensure that Vector128.CreateSequence works on x86 for non-constant 64-bit inputs#107053tannergooding merged 2 commits intodotnet:mainfrom
tannergooding merged 2 commits intodotnet:mainfrom
Conversation
ghost
added
the
area-CodeGen-coreclr
3 tasks
Member
Author
|
CC. @dotnet/jit-contrib for review. This resolves #106372 and will need backport to .NET 9 |
EgorBo
approved these changes
Aug 29, 2024
Member
Author
|
/backport to release/9.0 |
Contributor
|
Started backporting to release/9.0: https://github.com/dotnet/runtime/actions/runs/10619927730 |
4 tasks
jtschuster
pushed a commit
to jtschuster/runtime
that referenced
this pull request
Sep 17, 2024
…-bit inputs (dotnet#107053) * Ensure that Vector128.CreateSequence works on x86 for non-constant 64-bit inputs * Update Runtime_106372.cs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This resolves #106372
The issue was that the x86 path was only exiting for the path we had to do 64-bit multiplication. It did not also exit for the path that needed to do 64-bit broadcast.
Both of these issues are solvable, but is something to handle in the .NET 10 timeframe.