Ensure that AdvSimd.Insert doesn't zero out the upper bits #106981
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
area-CodeGen-coreclr
tannergooding
commented
Aug 26, 2024
| assert(intrin.op2->isContainedIntOrIImmed()); | ||
| assert(intrin.op2->AsIntCon()->gtIconVal == 0); | ||
| // fmov (scalar) zeros the upper bits and is not safe to use | ||
| assert(!intrin.op3->isContainedFltOrDblImmed()); |
Member
Author
There was a problem hiding this comment.
GitHub is displaying the diff a bit weirdly. This is just removing the if and fixing the indentation of the else block now that its the only code path.
Open
3 tasks
tannergooding
force-pushed
the
fix-106079
branch
from
e744d96 to
7e49c28
Compare
Member
Author
|
CC. @dotnet/jit-contrib for review, this resolves #106079 and needs backport to .NET 9. It should also be considered for backport to .NET 8 |
jakobbotsch
approved these changes
Aug 28, 2024
Member
Author
|
/backport to release/9.0 |
Contributor
|
Started backporting to release/9.0: https://github.com/dotnet/runtime/actions/runs/10599434161 |
4 tasks
Member
Author
|
/backport to release/8.0-staging |
Contributor
|
Started backporting to release/8.0-staging: https://github.com/dotnet/runtime/actions/runs/10599481780 |
4 tasks
jtschuster
pushed a commit
to jtschuster/runtime
that referenced
this pull request
Sep 17, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This resolves #106079
This bug was introduced in the first Arm64 support was added back in .NET 5: #35030