[release/9.0] Use OpenSSL 3's KBKDF for SP800-108 if it is available #106893
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Tagging subscribers to this area: @dotnet/area-system-security, @bartonjs, @vcsjones |
bartonjs
approved these changes
Aug 23, 2024
vcsjones
added
the
cryptographic-docs-impact
jeffhandley
approved these changes
Aug 23, 2024
|
@artl93 - For your review for .NET 9 RC2. This is a change in the theme of security and helping customers remain FIPS compliant in reaction to a recent change from NIST, and we would service for it. |
artl93
approved these changes
Aug 23, 2024
|
/ba-g The failures are unrelated known test issues occurring on many PRs right now |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #106779 to release/9.0
/cc @bartonjs @jeffhandley
Customer Impact
This changes the
SP800108HmacCounterKdfto use OpenSSL's KBKDF functionality instead of a managed implementation. If the OpenSSL version on the system does not support KBKDF, the implementation continues to fall back to the managed implementation.This is a reaction to NIST having a CAVP on SP800-108. This change helps customers meet compliance needs by using a FIPS component from OpenSSL if it is available. The managed implementation that was used on Linux previously is not FIPS validated.
Regression
Testing
Extensive unit tests existed for this functionality and were used to validate the OpenSSL implementation is compatible with the managed implementation.
Risk
Low. Tests ensure the new OpenSSL functionality works as expected.