Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Delete check for old PowerPC Rosetta from CoreCLR PAL #106763

Merged
merged 3 commits into from
Aug 22, 2024

Conversation

jkotas
Copy link
Member

@jkotas jkotas commented Aug 21, 2024

No description provided.

@jkotas
Copy link
Member Author

jkotas commented Aug 21, 2024

This check was part of the initial CoreCLR payload in 2015.

Copy link
Member

@janvorli janvorli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you!

@janvorli
Copy link
Member

Build break due to the now unused exit label:

/Users/runner/work/1/s/src/coreclr/pal/src/init/pal.cpp:711:1: error: unused label 'exit' [-Werror,-Wunused-label]
  exit :

@jkotas jkotas merged commit 2af0051 into dotnet:main Aug 22, 2024
90 checks passed
@jkotas jkotas deleted the delete-runningnatively branch August 22, 2024 04:34
@github-actions github-actions bot locked and limited conversation to collaborators Sep 21, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants