__ComObject invoke through reflection fix
#106677
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A regression was introduced that had __ComObject implement IDynamicInterfaceCastable. This means that the order of checks is now important. Made the order consistent in all places and added a test for this particular case.
jkotas
approved these changes
Aug 20, 2024
jkoritzinsky
approved these changes
Aug 20, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A regression was introduced that had
__ComObjectimplement
IDynamicInterfaceCastable. This meansthat the order of checks is now important. Made the
order consistent in all places and added a test for this
particular case.
Regression introduced in #105965 and found in dotnet/winforms#11916.
/cc @dotnet/interop-contrib