Replace TlsStream type by using SslStream directly #106451
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
|
Tagging subscribers to this area: @dotnet/ncl, @bartonjs, @vcsjones |
…eam.cs Co-authored-by: Miha Zupan <mihazupan.zupan1@gmail.com>
wfurt
reviewed
Aug 15, 2024
src/libraries/System.Net.Requests/src/System/Net/FtpDataStream.cs
Outdated
Show resolved
Hide resolved
wfurt
approved these changes
Aug 15, 2024
rzikm
commented
Aug 16, 2024
src/libraries/System.Net.Requests/src/System/Net/FtpDataStream.cs
Outdated
Show resolved
Hide resolved
This was referenced Aug 16, 2024
Closed
Closed
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up after #106362.
The
TlsStreamtype does not bring much useful behavior on top of plainSslStream, removing the type prevents issues like #99276 stemming from missing delegating overloads from resurfacing in the future.Summary of changes:
There was some extra plumbing necessary in case of System.Net.Requests where the code needs to manipulate the underlying NetworkStream (mainly accessing the Socket directly), so the original
NetworkStreamis being passed along as well where appropriate.