Skip to content

[release/9.0-rc1] Revert "Use Unsafe.BitCast for Int128UInt128 operators" #106431

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 15, 2024

Conversation

github-actions[bot]
Copy link
Contributor

@github-actions github-actions bot commented Aug 15, 2024

Backport of #106430 to release/9.0-rc1

/cc @stephentoub

Customer Impact

  • Customer reported
  • Found internally

[Select one or both of the boxes. Describe how this issue impacts customers, citing the expected and actual behaviors and scope of the issue. If customer-reported, provide the issue number.]

Regression

  • Yes
  • No

Automated revert of #104506, which triggered some performance regression test failures.

Testing

CI

Risk

Low. This just reverts a small cleanup PR that ended up regressing some perf tests.

@ghost ghost added the area-System.Numerics label Aug 15, 2024
Copy link
Contributor

Tagging subscribers to this area: @dotnet/area-system-numerics
See info in area-owners.md if you want to be subscribed.

@stephentoub stephentoub added this to the 9.0.0 milestone Aug 15, 2024
@stephentoub stephentoub added the Servicing-consider Issue for next servicing release review label Aug 15, 2024
@rbhanda rbhanda added Servicing-approved Approved for servicing release and removed Servicing-consider Issue for next servicing release review labels Aug 15, 2024
@carlossanlop carlossanlop merged commit 5694fe0 into release/9.0-rc1 Aug 15, 2024
149 of 155 checks passed
@carlossanlop carlossanlop deleted the backport/pr-106430-to-release/9.0-rc1 branch August 15, 2024 22:45
@github-actions github-actions bot locked and limited conversation to collaborators Sep 15, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-System.Numerics Servicing-approved Approved for servicing release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants