Skip to content

Revert "Implement type name resolution for ILLink analyzer" #106343

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 13, 2024

Conversation

sbomer
Copy link
Member

@sbomer sbomer commented Aug 13, 2024

Reverts #106209 to fix the build break while I investigate #106321

edit: Let's hold off on merging this until we have more information, see the discussion in that issue. People are still hitting the issue and I've confirmed the build fails with a global SDK install. We'll probably want to wait for .NET 10 to make the fix since it may need MSBuild to update binding redirects for SRM.

@sbomer sbomer requested a review from marek-safar as a code owner August 13, 2024 16:29
@ghost ghost added the area-Tools-ILLink .NET linker development as well as trimming analyzers label Aug 13, 2024
@dotnet-policy-service dotnet-policy-service bot added the linkable-framework Issues associated with delivering a linker friendly framework label Aug 13, 2024
Copy link
Contributor

Tagging subscribers to this area: @agocke, @sbomer, @vitek-karas
See info in area-owners.md if you want to be subscribed.

@sbomer sbomer added the NO-MERGE The PR is not ready for merge yet (see discussion for detailed reasons) label Aug 13, 2024
@agocke agocke closed this Aug 13, 2024
@agocke agocke reopened this Aug 13, 2024
@sbomer sbomer removed the NO-MERGE The PR is not ready for merge yet (see discussion for detailed reasons) label Aug 13, 2024
@sbomer sbomer merged commit 5ee1b86 into main Aug 13, 2024
77 checks passed
@jkotas jkotas deleted the revert-106209-analyzerTypeNameParser branch August 13, 2024 21:12
@github-actions github-actions bot locked and limited conversation to collaborators Sep 14, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-Tools-ILLink .NET linker development as well as trimming analyzers linkable-framework Issues associated with delivering a linker friendly framework
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants