Ensure side effects are preserved for Arm64 #105963
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
area-CodeGen-coreclr
tannergooding
commented
Aug 5, 2024
| // op3 has side effects, this would require us to append a new statement | ||
| // to ensure that it isn't lost, which isn't safe to do from the general | ||
| // purpose handler here. We'll recognize this and mark it in VN instead | ||
| break; |
Member
Author
There was a problem hiding this comment.
The break; here was apparently lost somewhere and so it was incorrectly folding down to op2 and losing the side effect
jakobbotsch
approved these changes
Aug 5, 2024
5 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This resolves #105818