JIT: Fix NumArgs for GetFfr* and CreateTrueMaskAll HW intrinsics

[jakobbotsch]

Fixes #105869 (comment).

[dotnet-policy-service]

Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch
See info in area-owners.md if you want to be subscribed.

[jakobbotsch]

cc @a74nh, can you check if this fixes the tests for you?

[a74nh]

Checking....

[a74nh]

Looks like the issue is still present with this PR

[mikabl-arm]

@jakobbotsch , seems that it doesn't fix the error we began to experience after 014632b . Have you encountered this assertion fail? Please let me know if the patch fixes the error for you.

Starting test: /home/mikabl01/dotnet/runtime/artifacts/tests/coreclr/linux.arm64.Checked/Tests/Core_Root/corerun -p System.Reflection.Metadata.MetadataUpdater.IsSupported=false -p System.Runtime.Serialization.EnableUnsafeBinaryFormatterSerialization=true ./artifacts/tests/coreclr/linux.arm64.Checked/JIT/HardwareIntri
nsics/HardwareIntrinsics_Arm_ro/HardwareIntrinsics_Arm_ro.dll GatherVectorFirstFaulting                                                                        
===================Running default===================                                                                                                                                                                                                                                                                         
------------------- {} -------------------                                                                                                                                                                                                                                                                                    
Errors:                                                                        
                                                                                                                                                                                                                                                                                                                              
Assert failure(PID 3447181 [0x0034998d], Thread: 3447181 [0x34998d]): Assertion failed 'vnStore->VNFuncArity(func) == 1' in 'JIT.HardwareIntrinsics.Arm._Sve.SveGatherVectorVectorBasesTest__Sve_GatherVectorFirstFaulting_Bases_double_ulong:RunBasicScenario_UnsafeRead():this' during 'Do value numbering' (IL size 110; ha
sh 0x04f13b09; FullOpts)                                                                                                                                                                                                                                                                                                      
                                                                                                                                                                                                                                                                                                                              
    File: /home/mikabl01/dotnet/runtime/src/coreclr/jit/valuenum.cpp:12998                                                                                                                                                                                                                                                    
    Image: /home/mikabl01/dotnet/runtime/artifacts/tests/coreclr/linux.arm64.Checked/Tests/Core_Root/corerun   

[jakobbotsch]

@jakobbotsch , seems that it doesn't fix the error we began to experience after 014632b . Have you encountered this assertion fail? Please let me know if the patch fixes the error for you.

Starting test: /home/mikabl01/dotnet/runtime/artifacts/tests/coreclr/linux.arm64.Checked/Tests/Core_Root/corerun -p System.Reflection.Metadata.MetadataUpdater.IsSupported=false -p System.Runtime.Serialization.EnableUnsafeBinaryFormatterSerialization=true ./artifacts/tests/coreclr/linux.arm64.Checked/JIT/HardwareIntri
nsics/HardwareIntrinsics_Arm_ro/HardwareIntrinsics_Arm_ro.dll GatherVectorFirstFaulting                                                                        
===================Running default===================                                                                                                                                                                                                                                                                         
------------------- {} -------------------                                                                                                                                                                                                                                                                                    
Errors:                                                                        
                                                                                                                                                                                                                                                                                                                              
Assert failure(PID 3447181 [0x0034998d], Thread: 3447181 [0x34998d]): Assertion failed 'vnStore->VNFuncArity(func) == 1' in 'JIT.HardwareIntrinsics.Arm._Sve.SveGatherVectorVectorBasesTest__Sve_GatherVectorFirstFaulting_Bases_double_ulong:RunBasicScenario_UnsafeRead():this' during 'Do value numbering' (IL size 110; ha
sh 0x04f13b09; FullOpts)                                                                                                                                                                                                                                                                                                      
                                                                                                                                                                                                                                                                                                                              
    File: /home/mikabl01/dotnet/runtime/src/coreclr/jit/valuenum.cpp:12998                                                                                                                                                                                                                                                    
    Image: /home/mikabl01/dotnet/runtime/artifacts/tests/coreclr/linux.arm64.Checked/Tests/Core_Root/corerun   

I have not reproduced it myself, no. I was hoping to be able to guess what the problem was. Let me spend some time to set up the environment to do that.

[jakobbotsch]

Same problem just for another HW intrinsic. Should fix it now.

[a74nh]

Same problem just for another HW intrinsic. Should fix it now.

This now fixes it for me (and @SwapnilGaikwad )

[jakobbotsch]

cc @dotnet/jit-contrib @dotnet/arm64-contrib PTAL @TIHan