Skip to content

Conversation

@github-actions
Copy link
Contributor

This PR was automatically generated to sync shared code changes from aspnetcore. Fixes dotnet/aspnetcore#18943

@eerhardt
Copy link
Member

cc @amcasey

@amcasey
Copy link
Member

amcasey commented Jul 31, 2024

I'm going to claim that my tests didn't break this

multiple attempts to download the nupkg have failed

@amcasey
Copy link
Member

amcasey commented Aug 1, 2024

[15:28:14] info: [FAIL] System.Tests.StringSplitTests.SplitCharSeparator(value: ",first,second,third,", separator: ',', count: 2147483647, options: None, expected: ["", "first", "second", "third", ""])
[15:28:14] info: Assert.Equal() Failure: Exception thrown during comparison
[15:28:14] info:                                         ↓ (pos 4)
[15:28:14] info: Expected: [null, "", "first", "second", "third"]
[15:28:14] info: Actual:   ["", "first", "second", "third", ""]
[15:28:14] info:                                            ↑ (pos 4)
[15:28:14] info: ---- System.NullReferenceException : Object reference not set to an instance of an object.
[15:28:14] info:    at System.Object.InvokeStub_StringSplitTests.SplitCharSeparator(Object , Span`1 )
[15:28:14] info:    at System.Reflection.MethodBaseInvoker.InvokeWithManyArgs(Object , BindingFlags , Binder , Object[] , CultureInfo )
[15:28:14] info: ----- Inner Stack Trace -----

@amcasey
Copy link
Member

amcasey commented Aug 1, 2024

Likely related to #105362

@amcasey amcasey merged commit d9fc0f1 into main Aug 2, 2024
@amcasey amcasey deleted the github-action/sync-aspnetcore-1722442622 branch August 2, 2024 17:49
@github-actions github-actions bot locked and limited conversation to collaborators Sep 2, 2024
@karelz karelz added this to the 9.0.0 milestone Sep 3, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

The runtime<->aspnetcore shared src is out of sync

6 participants