Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[release/9.0-preview7] Fix platform analyzer attribute order for MacCatalyst #105410

Merged
merged 1 commit into from
Jul 24, 2024
Merged

[release/9.0-preview7] Fix platform analyzer attribute order for MacCatalyst #105410

merged 1 commit into from
Jul 24, 2024
+11 −11

Commits on Jul 24, 2024

  1. Fix platform analyzer attribute order for MacCatalyst 

    We need to make sure the attribute for MacCatalyst comes _after_ the iOS one due to how MacCatalyst is a superset of iOS: https://learn.microsoft.com/en-us/dotnet/standard/analyzers/platform-compat-analyzer#platform-inclusion

This caused an error in aspnetcore in the latest dependency flow because the analyzer thought AesGcm is _only_ supported on MacCatalyst:
> error CA1416: (NETCORE_ENGINEERING_TELEMETRY=Build) This call site is reachable on all platforms. 'AesGcm.Decrypt(ReadOnlySpan<byte>, ReadOnlySpan<byte>, ReadOnlySpan<byte>, Span<byte>, ReadOnlySpan<byte>)' is only supported on: 'maccatalyst' 13.0 and later.
    @akoeplinger
    akoeplinger authored and github-actions committed Jul 24, 2024
    Configuration menu
    Copy the full SHA
    5df8ef6 View commit details
    Browse the repository at this point in the history