Skip to content

Conversation

@eiriktsarpalis
Copy link
Member

Even though this disables the impacted TestTypes_GeneratesExpectedJsonSchema test on mono runtimes which checks for syntactic equality, the TestTypes_SerializedValueMatchesGeneratedSchema which evaluates the schema still runs on all platforms.

Contributes to #103694.

@dotnet-policy-service
Copy link
Contributor

Tagging subscribers to this area: @dotnet/area-system-text-json, @gregsdennis
See info in area-owners.md if you want to be subscribed.

@vitek-karas
Copy link
Member

Please let me know if I don't understand it correctly:

If that is the case, then I'd say we should modify the test to simply not run on mono runtimes without an "ActiveIssue". Basically I'd like us to resolve this once and for all - thus resolving #103694, but then that means we should not have an "ActiveIssue" pointing to it in our tests.

@eiriktsarpalis
Copy link
Member Author

To me it still feels like something that we should eventually be fixing, e.g. if we release a JsonSchema type that implements semantic equality hence ActiveIssue rather than skip.

@vitek-karas
Copy link
Member

OK - I'll leave that up to you :-)

@eiriktsarpalis
Copy link
Member Author

eiriktsarpalis commented Jul 22, 2024

Thanks. Happy to create another issue if you think we should be looking at guaranteeing attribute ordering at the runtime level.

@eiriktsarpalis eiriktsarpalis merged commit 87a32e7 into dotnet:main Jul 22, 2024
@eiriktsarpalis eiriktsarpalis deleted the disable-ios-failing-test branch July 22, 2024 14:01
@github-actions github-actions bot locked and limited conversation to collaborators Aug 22, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants