Convert `GetMethodFromStackTrace` to QCall #105103

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merged

AaronRobinsonMSFT merged 3 commits into dotnet:main from AaronRobinsonMSFT:hmf_getmethodfromstacktrace

Jul 19, 2024

Member

AaronRobinsonMSFT commented Jul 18, 2024

No description provided.


          Convert GetMethodFromStackTrace to QCall

dd004b9

AaronRobinsonMSFT added the area-VM-coreclr label

AaronRobinsonMSFT added this to the 9.0.0 milestone

AaronRobinsonMSFT requested review from elinor-fung, janvorli and jkotas

July 18, 2024 17:09

dotnet-policy-service bot assigned AaronRobinsonMSFT

Contributor

dotnet-policy-service bot commented Jul 18, 2024

Tagging subscribers to this area: @mangod9
See info in area-owners.md if you want to be subscribed.

jkotas reviewed

View reviewed changes

src/coreclr/System.Private.CoreLib/src/System/Exception.CoreCLR.cs Outdated Show resolved Hide resolved

janvorli reviewed

View reviewed changes

src/coreclr/System.Private.CoreLib/src/System/Exception.CoreCLR.cs Outdated Show resolved Hide resolved

src/coreclr/System.Private.CoreLib/src/System/Exception.CoreCLR.cs Outdated Show resolved Hide resolved

build-analysis bot mentioned this pull request

'System.Net.NameResolution.Functional.Tests' Failure #105092

Closed


          Feedback.

160b443

huoyaoyuan reviewed

View reviewed changes

src/coreclr/System.Private.CoreLib/src/System/Exception.CoreCLR.cs Outdated Show resolved Hide resolved

jkotas reviewed

View reviewed changes

src/coreclr/System.Private.CoreLib/src/System/Exception.CoreCLR.cs Outdated Show resolved Hide resolved

jkotas reviewed

View reviewed changes

src/coreclr/System.Private.CoreLib/src/System/Exception.CoreCLR.cs Outdated Show resolved Hide resolved

jkotas reviewed

View reviewed changes

src/coreclr/System.Private.CoreLib/src/System/Exception.CoreCLR.cs Outdated Show resolved Hide resolved

jkotas reviewed

View reviewed changes

src/coreclr/System.Private.CoreLib/src/System/Exception.CoreCLR.cs Outdated Show resolved Hide resolved

jkotas approved these changes

View reviewed changes

Member

jkotas left a comment

LGTM otherwise. Thanks!


          Feedback.

0f01b3b

build-analysis bot mentioned this pull request

System.IO.Net5Compat.Tests and System.IO.Tests suddenly exiting with error 137 #100558

Closed

AaronRobinsonMSFT merged commit d461cdb into dotnet:main

AaronRobinsonMSFT deleted the hmf_getmethodfromstacktrace branch

July 19, 2024 18:03

build-analysis bot mentioned this pull request

nativeaot\\SmokeTests\\Reflection\\Reflection\\Reflection.cmd fails with Access Violation #105136

Closed

jakobbotsch mentioned this pull request

JIT/IL_Conformance/Convert/TestConvertFromIntegral/TestConvertFromIntegral failing in CI with "Assert failure: arrayBaseRef->GetArrayElementType() == ELEMENT_TYPE_OBJECT" #105186

Closed

github-actions bot locked and limited conversation to collaborators

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

area-VM-coreclr