Skip to content

[NO REVIEW] Investigate Http20.AllSocketsHttpHandlerCounters_Success_Recorded #105081

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
liveans wants to merge 3 commits into from
Closed

[NO REVIEW] Investigate Http20.AllSocketsHttpHandlerCounters_Success_Recorded #105081

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
9d8adad
Activate TestListener
liveans Jul 18, 2024
dd7338e
Make testeventlistener specific for HTTP/2
liveans Jul 18, 2024
6489b28
Merge branch 'main' into investigate_101285
liveans Jul 30, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions src/libraries/System.Net.Http/tests/FunctionalTests/MetricsTest.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,7 @@
using System.Threading.Tasks;
using Microsoft.DotNet.RemoteExecutor;
using Microsoft.DotNet.XUnitExtensions;
using TestUtilities;
using Xunit;
using Xunit.Abstractions;

Expand Down Expand Up @@ -687,6 +688,11 @@ await LoopbackServerFactory.CreateClientAndServerAsync(async uri =>
[ConditionalFact(typeof(SocketsHttpHandler), nameof(SocketsHttpHandler.IsSupported))]
public async Task AllSocketsHttpHandlerCounters_Success_Recorded()
{
TestEventListener? listener = null;
if (UseVersion == HttpVersion20.Value)
{
listener = new TestEventListener(_output, TestEventListener.NetworkingEvents);
}
TaskCompletionSource clientWaitingTcs = new(TaskCreationOptions.RunContinuationsAsynchronously);
TaskCompletionSource clientDisposedTcs = new(TaskCreationOptions.RunContinuationsAsynchronously);

Expand Down Expand Up @@ -758,6 +764,7 @@ await server.AcceptConnectionAsync(async connection =>
await clientDisposedTcs.Task.WaitAsync(TestHelper.PassingTestTimeout);
});
});
listener?.Dispose();
}

[Fact]
Expand Down