Don't throw when deserializing SettingsPropertyValue that's not byte[] #105057
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
Contributor
|
Tagging subscribers to this area: @dotnet/area-system-configuration |
ericstj
added
the
binaryformatter-migration
stephentoub
reviewed
Jul 18, 2024
.../System.Configuration.ConfigurationManager/src/System/Configuration/SettingsPropertyValue.cs
Show resolved
Hide resolved
stephentoub
approved these changes
Jul 18, 2024
This was referenced Jul 18, 2024
adamsitnik
approved these changes
Jul 18, 2024
Member
adamsitnik
left a comment
adamsitnik
left a comment
There was a problem hiding this comment.
LGTM, thank you @ericstj !
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #104914, #29429
As mentioned in the issue, this problem was introduced in net6.0 when
EnableUnsafeBinaryFormatterInPropertyValueSerializationcheck was added.Previously this would not even hit BinaryFormatter, it would thow when casting to
byte[]and that would be caught and execution would continue.With the change in 6.0 it began throwing when
EnableUnsafeBinaryFormatterInPropertyValueSerializationwas not set. To avoid this, we'll test first if we could even useBinaryFormatterbefore consulting the flag to throw.This also fixes #29429 which was caused by contention for user.config between the tests in
LocalFileSettingsProviderTests.