Fix EH stacktrace keepalive array copy size #104912
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When the stacktrace keepalive array is grown, we were incorrectly copying extra item from the original keepalive array to the new one. In some cases, it ended up adding garbage to the array and GC object verification has hickuped on it. In the CI, it was only hit by GCStress-Extra tests that set DOTNET_HeapVerify=1 so far. This fixes the copied size to be the source array's number of elements. Close dotnet#104878
|
FYI: @jakobbotsch |
jkotas
approved these changes
Jul 16, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the stacktrace keepalive array is grown, we were incorrectly copying extra item from the original keepalive array to the new one. In some cases, it ended up adding garbage to the array and GC object verification has hickuped on it. In the CI, it was only hit by GCStress-Extra tests that set DOTNET_HeapVerify=1 so far.
This fixes the copied size to be the source array's number of elements.
Close #104878