Skip to content

Replace Ubuntu 18 images with Ubuntu 20 in ARM 64 runs #104689

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jul 12, 2024
Merged

Replace Ubuntu 18 images with Ubuntu 20 in ARM 64 runs #104689

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
f334da8
Disable (No)ClientCert_DefaultValue_ResumeSucceeds only on Ubuntu 18 ARM
rzikm Jul 10, 2024
c300129
Update ubuntu images to 20.04 instead
rzikm Jul 11, 2024
0d42116
Use Ubuntu 22.04
rzikm Jul 11, 2024
6a7bb7d
Revert "Use Ubuntu 22.04"
rzikm Jul 12, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions eng/pipelines/coreclr/templates/helix-queues-setup.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -70,9 +70,9 @@ jobs:
# Linux arm64
- ${{ if eq(parameters.platform, 'linux_arm64') }}:
- ${{ if eq(variables['System.TeamProject'], 'public') }}:
- (Ubuntu.1804.Arm64.Open)Ubuntu.2004.Armarch.Open@mcr.microsoft.com/dotnet-buildtools/prereqs:ubuntu-18.04-helix-arm64v8
- (Ubuntu.2004.Arm64.Open)Ubuntu.2004.Armarch.Open@mcr.microsoft.com/dotnet-buildtools/prereqs:ubuntu-20.04-helix-arm64v8
- ${{ if eq(variables['System.TeamProject'], 'internal') }}:
- (Ubuntu.1804.Arm64)Ubuntu.2004.ArmArch@mcr.microsoft.com/dotnet-buildtools/prereqs:ubuntu-18.04-helix-arm64v8
- (Ubuntu.2004.Arm64)Ubuntu.2004.ArmArch@mcr.microsoft.com/dotnet-buildtools/prereqs:ubuntu-20.04-helix-arm64v8

# Linux musl x64
- ${{ if eq(parameters.platform, 'linux_musl_x64') }}:
Expand Down
6 changes: 2 additions & 4 deletions src/libraries/System.Net.Security/tests/FunctionalTests/SslStreamAllowTlsResumeTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -134,9 +134,8 @@ await TestConfiguration.WhenAllOrAnyFailedWithTimeout(
server.Dispose();
}

[ConditionalTheory]
[Theory]
[MemberData(nameof(SslProtocolsData))]
[ActiveIssue("https://github.com/dotnet/runtime/issues/103354", typeof(PlatformDetection), nameof(PlatformDetection.IsArmOrArm64Process))]
public Task NoClientCert_DefaultValue_ResumeSucceeds(SslProtocols sslProtocol)
{
SslServerAuthenticationOptions serverOptions = new SslServerAuthenticationOptions
Expand Down Expand Up @@ -189,9 +188,8 @@ public static TheoryData<SslProtocols, bool, ClientCertSource> ClientCertTestDat
return data;
}

[ConditionalTheory]
[Theory]
[MemberData(nameof(ClientCertTestData))]
[ActiveIssue("https://github.com/dotnet/runtime/issues/103354", typeof(PlatformDetection), nameof(PlatformDetection.IsArmOrArm64Process))]
public Task ClientCert_DefaultValue_ResumeSucceeds(SslProtocols sslProtocol, bool certificateRequired, ClientCertSource certSource)
{
SslServerAuthenticationOptions serverOptions = new SslServerAuthenticationOptions
Expand Down