Skip to content

Get ThreadContext for AVX registers #104514

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

mikelle-rogers
Copy link
Member

@mikelle-rogers mikelle-rogers commented Jul 6, 2024

In MachExceptionInfo constructor, update the AVX registers using thread_get_state.
This fixes #78991.
We found that the null reference exception happened because we were not updating the upper half of the ymm register in the MachExceptionInfo. This caused only part of a structure to be copied from the ymm register to a new location. Instead of the second half of the structure in the new location, there were zeros.

@mikelle-rogers mikelle-rogers marked this pull request as ready for review July 6, 2024 20:46
@mikelle-rogers mikelle-rogers requested review from janvorli and a team July 6, 2024 21:25
@mikelle-rogers mikelle-rogers requested a review from jkotas July 9, 2024 00:31
@jkotas
Copy link
Member

jkotas commented Jul 9, 2024

The shape of the change looks good to me now. It will defer to @janvorli to signoff.

Copy link
Member

@janvorli janvorli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you!

@janvorli janvorli merged commit 5b5d791 into dotnet:main Jul 9, 2024
89 checks passed
matouskozak added a commit to matouskozak/runtime that referenced this pull request Jul 11, 2024
@janvorli
Copy link
Member

/azp backport to release/8.0-staging

@hoyosjs
Copy link
Member

hoyosjs commented Jul 12, 2024

/backport to release/8.0-staging

Copy link
Contributor

Started backporting to release/8.0-staging: https://github.com/dotnet/runtime/actions/runs/9912412663

@github-actions github-actions bot locked and limited conversation to collaborators Aug 12, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
4 participants