Add support for other same size vector bitcasts to Mono - #104309
Merged
Conversation
ghost
added
the
tannergooding
changed the title
tannergooding
force-pushed
the
mono-vectoras-2
branch
from
July 2, 2024 17:26
c6aec4c to
1303d56
Compare
Contributor
|
Tagging subscribers to this area: @steveisok, @lambdageek |
tannergooding
force-pushed
the
mono-vectoras-2
branch
from
July 2, 2024 18:11
1303d56 to
8778938
Compare
This was referenced Jul 3, 2024
Closed
Open
tannergooding
force-pushed
the
mono-vectoras-2
branch
from
July 3, 2024 02:19
93e5874 to
6713a79
Compare
tannergooding
marked this pull request as ready for review
July 3, 2024 11:02
tannergooding
requested review from
BrzVlad,
fanyang-mono and
kotlarmilos
as code owners
July 3, 2024 11:02
Member
Author
|
This should be ready for review and gets the rest of the same size vector bitcast support in for Mono (including interpreter). |
This was referenced Jul 3, 2024
Member
Author
|
CC. @steveisok, @kg for the MonoInterp side of things |
kg
reviewed
Jul 3, 2024
kg
reviewed
Jul 3, 2024
kg
reviewed
Jul 3, 2024
kg
approved these changes
Jul 3, 2024
xtqqczze
added a commit
to xtqqczze/dotnet-runtime
that referenced
this pull request
Jul 10, 2024
Follow-up to dotnet#104309.
xtqqczze
added a commit
to xtqqczze/dotnet-runtime
that referenced
this pull request
Jul 12, 2024
Follow-up to dotnet#104309.
xtqqczze
added a commit
to xtqqczze/dotnet-runtime
that referenced
this pull request
Jul 12, 2024
Follow-up to dotnet#104309.
xtqqczze
added a commit
to xtqqczze/dotnet-runtime
that referenced
this pull request
Jul 16, 2024
Follow-up to dotnet#104309.
xtqqczze
added a commit
to xtqqczze/dotnet-runtime
that referenced
this pull request
Jul 17, 2024
Follow-up to dotnet#104309.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This covers other same size casts such as between
Vector128<float>andPlane,Quaternion, andVector4. It also covers conversion betweenVector<T>andVector128<T>