increase the allocation threshold for tests that need to ensure that 2GB+ does not get pre-allocated #104151
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…2GB+ does not get pre-allocated, fixes dotnet#103550
jkotas
reviewed
Jun 28, 2024
| // but it reports allocations for all threads. Using this API would require | ||
| // ensuring that it's the only test that is being run at a time. | ||
| // Mono either allocates more than expected or the API is not precise enough | ||
| // Mono either allocates more than expected or the API is not precise enough. |
Member
There was a problem hiding this comment.
Is this suppression still valid after this change?
Member
Author
There was a problem hiding this comment.
I am going to use the CI to find out
jkotas
approved these changes
Jun 28, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #103550