Skip to content

prevent feeding too much data to schannel during renegotiation #104130

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -478,14 +478,38 @@ private ProtocolToken ProcessTlsFrame(int frameSize)

frameSize = nextHeader.Length;

// Can process more handshake frames in single step or during TLS1.3 post-handshake auth, but we should
// avoid processing too much so as to preserve API boundary between handshake and I/O.
if ((nextHeader.Type != TlsContentType.Handshake && nextHeader.Type != TlsContentType.ChangeCipherSpec) && !_isRenego || frameSize > _buffer.EncryptedLength)
if (frameSize > _buffer.EncryptedLength)
{
// We don't have full frame left or we already have app data which needs to be processed by decrypt.
// We don't have full frame left
break;
}

if (OperatingSystem.IsWindows())
{
// Windows is strange in a way how they handle renegotiation and part of TLS 1.3 handshake.
// If we feed it too much data it will choke.

if (_lastFrame.Header.Type == TlsContentType.ChangeCipherSpec && nextHeader.Type == TlsContentType.Handshake)
{
// We are getting late handshake frames. This can be sign or renegotiation.
// It is OK to be wrong here, the flag primarily ensures that we are not feeding schannel too much data
_isRenego = true;
}

if (_isRenego)
{
break;
}

// Can process more handshake frames in single step or during TLS1.3 post - handshake auth, but we should
// avoid processing too much so as to preserve API boundary between handshake and I/O.
if ((nextHeader.Type != TlsContentType.Handshake && nextHeader.Type != TlsContentType.ChangeCipherSpec))
{
// We don't have full frame left or we already have app data which needs to be processed by decrypt.
break;
}
}

chunkSize += frameSize;
_buffer.DiscardEncrypted(frameSize);
}
Expand Down
Loading