Skip to content

Conversation

am11
Copy link
Member

@am11 am11 commented Jun 27, 2024

@ghost ghost added the needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners label Jun 27, 2024
@dotnet-policy-service dotnet-policy-service bot added the community-contribution Indicates that the PR has been added by a community member label Jun 27, 2024
@am11 am11 added area-Infrastructure-libraries and removed needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners labels Jun 27, 2024
Copy link
Contributor

Tagging subscribers to this area: @dotnet/area-infrastructure-libraries
See info in area-owners.md if you want to be subscribed.

@jkotas
Copy link
Member

jkotas commented Jun 27, 2024

@tomeksowi @yurai007 Does this detect the QEMU RISCV environment that you are using to run tests?

@am11 am11 force-pushed the feature/minipal/qemu-detection branch 2 times, most recently from f0eacc3 to 3a7fa93 Compare June 27, 2024 23:28
@am11 am11 force-pushed the feature/minipal/qemu-detection branch from e4030bf to 98484de Compare June 28, 2024 06:15
@am11
Copy link
Member Author

am11 commented Jun 28, 2024

GC scenario test failure seems to be #63774, unrelated to changes.

@yurai007
Copy link
Contributor

@tomeksowi @yurai007 Does this detect the QEMU RISCV environment that you are using to run tests?

@jkotas: let me check this, I will share results soon.

@jkotas
Copy link
Member

jkotas commented Jul 1, 2024

Given that this is not a reliable method to detect QEMU, I do not think that it is a good fit for minipal and production code.

@am11
Copy link
Member Author

am11 commented Jul 1, 2024

@jkotas did you try it?

@jkotas
Copy link
Member

jkotas commented Jul 1, 2024

@jkotas did you try it?

I did not. I can believe what @yurai007 says.

I do not particularly like that the change has 3 different ways to guess whether the process is running under QEMU. It suggests that it is not reliable. I wish there was one proper way to detect QEMU that is documented on https://qemu.org/.

@am11 am11 closed this Jul 1, 2024
@am11 am11 deleted the feature/minipal/qemu-detection branch July 1, 2024 14:01
@github-actions github-actions bot locked and limited conversation to collaborators Aug 2, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-Infrastructure-libraries community-contribution Indicates that the PR has been added by a community member
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants