Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ARm64/Sve: Fix the SVE_ComputeAddress* #104039

Merged
merged 3 commits into from
Jun 27, 2024
Merged

ARm64/Sve: Fix the SVE_ComputeAddress* #104039

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
5e23916
Fix the SVE_ComputeAddress*
kunalspathak Jun 26, 2024
fe89f4c
review comments
kunalspathak Jun 26, 2024
c4997ab
fix the typo
kunalspathak Jun 26, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion src/coreclr/jit/hwintrinsic.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -555,8 +555,10 @@ struct HWIntrinsicInfo
return static_cast<CORINFO_InstructionSet>(result);
}

#ifdef TARGET_XARCH
#if defined(TARGET_XARCH)
static int lookupIval(Compiler* comp, NamedIntrinsic id, var_types simdBaseType);
#elif defined(TARGET_ARM64)
static int lookupIval(NamedIntrinsic id);
#endif

static bool tryLookupSimdSize(NamedIntrinsic id, unsigned* pSimdSize)
Expand Down
25 changes: 25 additions & 0 deletions src/coreclr/jit/hwintrinsicarm64.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -152,6 +152,31 @@ CORINFO_InstructionSet HWIntrinsicInfo::lookupIsa(const char* className, const c
return InstructionSet_ILLEGAL;
}

//------------------------------------------------------------------------
// lookupIval: Gets a the implicit immediate value for the given intrinsic
//
// Arguments:
// id - The intrinsic for which to get the ival
//
// Return Value:
// The immediate value for the given intrinsic or -1 if none exists
int HWIntrinsicInfo::lookupIval(NamedIntrinsic id)
{
switch (id)
{
case NI_Sve_Compute16BitAddresses:
return 1;
case NI_Sve_Compute32BitAddresses:
return 2;
case NI_Sve_Compute64BitAddresses:
return 3;
case NI_Sve_Compute8BitAddresses:
return 0;
default:
unreached();
}
return -1;
}
//------------------------------------------------------------------------
// isFullyImplementedIsa: Gets a value that indicates whether the InstructionSet is fully implemented
//
Expand Down
6 changes: 1 addition & 5 deletions src/coreclr/jit/hwintrinsiccodegenarm64.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2118,12 +2118,8 @@ void CodeGen::genHWIntrinsic(GenTreeHWIntrinsic* node)
case NI_Sve_Compute32BitAddresses:
case NI_Sve_Compute64BitAddresses:
{
static_assert_no_msg(AreContiguous(NI_Sve_Compute16BitAddresses, NI_Sve_Compute32BitAddresses,
NI_Sve_Compute64BitAddresses, NI_Sve_Compute8BitAddresses));

GetEmitter()->emitInsSve_R_R_R_I(ins, EA_SCALABLE, targetReg, op1Reg, op2Reg,
(intrin.id - NI_Sve_Compute16BitAddresses), opt,
INS_SCALABLE_OPTS_LSL_N);
HWIntrinsicInfo::lookupIval(intrin.id), opt, INS_SCALABLE_OPTS_LSL_N);
break;
}

Expand Down
Loading