Skip to content

Conversation

jakobbotsch
Copy link
Member

The assertions created/used need to take into account that qmark arms are only conditionally executed.

The assertions created/used need to take into account that qmark arms
are only conditionally executed.
@ghost ghost added the area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI label Jun 24, 2024
Copy link
Contributor

Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch
See info in area-owners.md if you want to be subscribed.

@jakobbotsch
Copy link
Member Author

@jkoritzinsky looks like there's some issues with the new jit-format job.

@jkoritzinsky
Copy link
Member

Looking into it now

@jakobbotsch
Copy link
Member Author

jakobbotsch commented Jun 25, 2024

Oddly large TP regressions. Apparently MSVC decided to stop inlining PushValue into PreOrderVisit:

Base: 106512123541, Diff: 106622408758, +0.1035%

250103641  : NA      : 62.46% : +0.2348% : private: void __cdecl LocalAddressVisitor::PushValue(struct GenTree **)                                                             
4952204    : +0.53%  : 1.24%  : +0.0046% : memset                                                                                                                              
-1087515   : -0.20%  : 0.27%  : -0.0010% : public: enum Compiler::fgWalkResult __cdecl GenTreeVisitor<class LocalAddressVisitor>::WalkTree(struct GenTree **, struct GenTree *)
-1087515   : -0.20%  : 0.27%  : -0.0010% : public: enum Compiler::fgWalkResult __cdecl LocalAddressVisitor::PostOrderVisit(struct GenTree **, struct GenTree *)                
-142728597 : -25.54% : 35.64% : -0.1340% : public: enum Compiler::fgWalkResult __cdecl LocalAddressVisitor::PreOrderVisit(struct GenTree **, struct GenTree *)                 

@jakobbotsch jakobbotsch marked this pull request as ready for review June 25, 2024 18:08
@jakobbotsch
Copy link
Member Author

cc @dotnet/jit-contrib PTAL @AndyAyersMS

No diffs. Large TP regressions from the inlining change shown in the comment above... I am hopeful that native PGO is going to sort that out.

@jakobbotsch jakobbotsch requested a review from AndyAyersMS June 25, 2024 18:09
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants