[LoongArch64] Add nativeaot support on LoongArch64. by sunlijun-610 · Pull Request #103889 · dotnet/runtime

sunlijun-610 · 2024-06-24T09:55:51Z

This PR adds nativeaot support on LoongArch64.

sunlijun-610 · 2024-06-24T10:00:35Z

Hi, @MichalStrehovsky @shushanhf
Could you please review this PR? Thanks!

sunlijun-610 · 2024-06-25T11:56:30Z

Excuse me for giving you so much trouble. Cause this is my first time submitting code, I made many low-level mistakes. Thanks very much for your reviews and guidance on me!
I’ve submitted the second patch correcting the mistakes.
Thanks!

filipnavara · 2024-06-25T12:04:42Z

Excuse me for giving you so much trouble. Cause this is my first time submitting code, I made many low-level mistakes. Thanks very much for your reviews and guidance on me!

No trouble at all. The purpose of the review process is to find those mistakes and it seems to work reasonably well here.

Side-note: I skimmed over most of the PR changes and looked for things that bit me during the linux-arm / win-x86 ports. The object writer part looks alright save for one comment.

…r/ElfObjectWriter.cs Co-authored-by: Filip Navara <filip.navara@gmail.com>

jkotas · 2024-06-26T03:31:04Z

No trouble at all.

+1

This change is a lot of lines that touching number of different areas. It tends to be better to split changes like this into multiple smaller PRs. For example:

Runtime assembly code (*.S) file
Changes in ObjectWriter component
Everything else

If you prefer to continue with the PR as is, it is certainly fine - but it is likely to take longer to get it in compared if it is broken into multiple smaller PRs.

sunlijun-610 · 2024-06-26T04:49:03Z

This change is a lot of lines that touching number of different areas. It tends to be better to split changes like this into multiple smaller PRs.

OK, got it. I'll split this PR into multiple smaller PRs as soon as possible. Thanks!

sunlijun-610 · 2024-06-27T02:41:53Z

After splitting, part-1 has been submitted to new PR: #104066

sunlijun-610 · 2024-06-27T09:45:39Z

After splitting:
Part-2 has been submitted to new PR: #104084
Part-3 has been submitted to new PR: #104087
Part-4 has been submitted to this PR, covering the previous, and it's the last PR.

shushanhf

LGTM
Thanks

shushanhf

sorry for mistake click.
@sunlijun-610 please test these PRs based on the new PRs.
Thanks

Co-authored-by: Jan Kotas <jkotas@microsoft.com>

sunlijun-610 · 2024-07-04T02:26:21Z

@sunlijun-610 please test these PRs based on the new PRs.

I've tested based on the new PRs and the latest commit, and no new failure cases added.
Thanks!

jkotas

LGTM modulo one last nit

jkotas · 2024-07-05T05:24:01Z

/azp run runtime-nativeaot-outerloop

azure-pipelines · 2024-07-05T05:24:16Z

Azure Pipelines successfully started running 1 pipeline(s).

jkotas · 2024-07-06T01:54:08Z

Filled #104500 on windows-arm64 Release NativeAOT_Libs failure

[LoongArch64] Add nativeaot support on LoongArch64.

c88d079

sunlijun-610 requested a review from MichalStrehovsky as a code owner June 24, 2024 09:55

ghost added the area-NativeAOT-coreclr label Jun 24, 2024

dotnet-policy-service Bot added the community-contribution Indicates that the PR has been added by a community member label Jun 24, 2024

huoyaoyuan reviewed Jun 24, 2024

View reviewed changes

jkotas added the arch-loongarch64 label Jun 24, 2024

filipnavara reviewed Jun 24, 2024

View reviewed changes

am11 reviewed Jun 24, 2024

View reviewed changes

Comment thread src/native/external/llvm-libunwind/src/Registers.hpp

am11 reviewed Jun 24, 2024

View reviewed changes

Comment thread src/coreclr/tools/aot/ILCompiler.Compiler/Compiler/ObjectWriter/CodeView/CodeViewNative.cs

am11 reviewed Jun 24, 2024

View reviewed changes

Comment thread src/coreclr/tools/aot/ILCompiler.Compiler/Compiler/ObjectWriter/Dwarf/DwarfCie.cs Outdated

filipnavara reviewed Jun 25, 2024

View reviewed changes

Comment thread src/coreclr/nativeaot/Runtime/loongarch64/ExceptionHandling.S Outdated

Comment thread src/coreclr/nativeaot/Runtime/unix/unixasmmacrosloongarch64.inc Outdated

huoyaoyuan reviewed Jun 25, 2024

View reviewed changes

Comment thread src/coreclr/nativeaot/Runtime/loongarch64/AllocFast.S Outdated

filipnavara reviewed Jun 25, 2024

View reviewed changes

Comment thread src/coreclr/tools/aot/ILCompiler.Compiler/Compiler/ObjectWriter/ElfObjectWriter.cs Outdated

sunlijun-610 added 2 commits June 25, 2024 19:34

Merge branch 'main' into main2

8a90e05

Correct mistakes in the first patch.

88f8268

filipnavara reviewed Jun 25, 2024

View reviewed changes

Comment thread src/coreclr/tools/aot/ILCompiler.Compiler/Compiler/ObjectWriter/ElfObjectWriter.cs Outdated

Update src/coreclr/tools/aot/ILCompiler.Compiler/Compiler/ObjectWrite…

cdc7591

…r/ElfObjectWriter.cs Co-authored-by: Filip Navara <filip.navara@gmail.com>

build-analysis Bot mentioned this pull request Jun 25, 2024

The Operation will be canceled. The next steps may not contain expected logs. dotnet/dnceng#3008

Open

3 tasks

am11 reviewed Jun 26, 2024

View reviewed changes

Comment thread src/coreclr/tools/aot/ILCompiler.Compiler/Compiler/ObjectWriter/ElfObjectWriter.cs Outdated

shushanhf reviewed Jun 26, 2024

View reviewed changes

Comment thread src/coreclr/tools/Common/Compiler/DependencyAnalysis/Target_LoongArch64/LoongArch64Emitter.cs Outdated

This was referenced Jun 27, 2024

Test failure: GC\\Scenarios\\FinalizeTimeout\\FinalizeTimeout\\FinalizeTimeout.cmd #103874

Closed

The job running on agent NetCore-Public ran longer than the maximum time #104044

Closed

jkotas reviewed Jun 27, 2024

View reviewed changes

Comment thread src/coreclr/nativeaot/Runtime/startup.cpp Outdated

jkotas reviewed Jun 27, 2024

View reviewed changes

Comment thread src/coreclr/nativeaot/Runtime/unix/PalRedhawkInline.h Outdated

jkotas reviewed Jun 27, 2024

View reviewed changes

Comment thread src/coreclr/nativeaot/Runtime/EHHelpers.cpp Outdated

jkotas reviewed Jun 27, 2024

View reviewed changes

Comment thread src/coreclr/nativeaot/Runtime/EHHelpers.cpp Outdated

Update EHHelpers.cpp and startup.cpp in nativeaot-runtime.

a947936

jkotas reviewed Jun 28, 2024

View reviewed changes

sunlijun-610 added 2 commits July 1, 2024 11:25

Revert src/coreclr/nativeaot/Runtime/startup.cpp.

9d378f9

Revert src/coreclr/nativeaot/Runtime/unix/PalRedhawkInline.h

809b638

build-analysis Bot mentioned this pull request Jul 2, 2024

Assertion in BigIntegerCalculator #103247

Closed

shushanhf approved these changes Jul 2, 2024

View reviewed changes

shushanhf reviewed Jul 2, 2024

View reviewed changes

jkotas reviewed Jul 3, 2024

View reviewed changes

Comment thread src/coreclr/nativeaot/Runtime/PalRedhawkCommon.h Outdated

jkotas reviewed Jul 3, 2024

View reviewed changes

Comment thread src/coreclr/nativeaot/Runtime/PalRedhawk.h Outdated

Update src/coreclr/nativeaot/Runtime/PalRedhawkCommon.h

c60ed12

Co-authored-by: Jan Kotas <jkotas@microsoft.com>

build-analysis Bot mentioned this pull request Jul 3, 2024

NuGet restore failing with NullReferenceException #103823

Closed

Update MiscHelpers.cpp and PalRedhawk.h in nativeaot-runtime

474d483

jkotas reviewed Jul 4, 2024

View reviewed changes

Comment thread src/coreclr/nativeaot/Runtime/PalRedhawkCommon.h

jkotas reviewed Jul 4, 2024

View reviewed changes

Comment thread src/coreclr/nativeaot/Runtime/gcenv.ee.cpp Outdated

jkotas approved these changes Jul 4, 2024

View reviewed changes

Update src/coreclr/nativeaot/Runtime/gcenv.ee.cpp

c8ab84b

build-analysis Bot mentioned this pull request Jul 5, 2024

System.Runtime.InteropServices.JavaScript.Tests.WebWorkerTest.JSDelay_ContinueWith_Sync test failed #103080

Closed

jkotas merged commit aee78d3 into dotnet:main Jul 6, 2024

github-actions Bot locked and limited conversation to collaborators Aug 5, 2024

Uh oh!

Conversation

sunlijun-610 commented Jun 24, 2024

Uh oh!

sunlijun-610 commented Jun 24, 2024

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

sunlijun-610 commented Jun 25, 2024

Uh oh!

Uh oh!

filipnavara commented Jun 25, 2024

Uh oh!

jkotas commented Jun 26, 2024

Uh oh!

sunlijun-610 commented Jun 26, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

sunlijun-610 commented Jun 27, 2024

Uh oh!

sunlijun-610 commented Jun 27, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

shushanhf left a comment

Choose a reason for hiding this comment

Uh oh!

shushanhf left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

sunlijun-610 commented Jul 4, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

jkotas left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

jkotas commented Jul 5, 2024

Uh oh!

azure-pipelines Bot commented Jul 5, 2024

Uh oh!

jkotas commented Jul 6, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

sunlijun-610 commented Jun 26, 2024 •

edited

Loading

sunlijun-610 commented Jun 27, 2024 •

edited

Loading

sunlijun-610 commented Jul 4, 2024 •

edited

Loading

jkotas left a comment •

edited

Loading