Use span-based dictionary lookup in System.Console #103742
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Tagging subscribers to this area: @dotnet/area-system-console |
adamsitnik
reviewed
Jun 20, 2024
src/libraries/System.Console/src/System/TerminalFormatStrings.cs
Outdated
Show resolved
Hide resolved
eiriktsarpalis
approved these changes
Jun 20, 2024
This was referenced Jun 20, 2024
Open
| @@ -62,14 +62,15 @@ private static bool TryParseTerminalInputSequence(char[] buffer, TerminalFormatS | |||
| return false; | |||
| } | |||
|
|
|||
| Dictionary<ReadOnlyMemory<char>, ConsoleKeyInfo> terminfoDb = terminalFormatStrings.KeyFormatToConsoleKey; // the most important source of truth | |||
| Dictionary<string, ConsoleKeyInfo>.AlternateLookup<ReadOnlySpan<char>> terminfoDb = // the most important source of truth | |||
There was a problem hiding this comment.
Shouldn't we be caching the alternate lookup struct somewhere? This is incurring a runtime type test against a generic interface which presumably would add up assuming this is a performance sensitive application.
There was a problem hiding this comment.
Didn't seem worth trying to avoid the overhead of a cast as part of the handling of a user's key strokes?
adamsitnik
approved these changes
Jun 21, 2024
|
/ba-g failures are known |
rzikm
pushed a commit
to rzikm/dotnet-runtime
that referenced
this pull request
Jun 24, 2024
* Use span-based dictionary lookup in System.Console * Fix ctor
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.