Generalize IControlFlowGraph successors - #103676
Merged
Merged
Conversation
- Move IsConditional on block to ConditionKind on branch - Introduce GetSuccessors to replace GetConditionalSuccessor and GetFallThroughSuccessor
ghost
added
the
area-Tools-ILLink
dotnet-policy-service
Bot
added
the
linkable-framework
Contributor
|
Tagging subscribers to this area: @agocke, @sbomer, @vitek-karas |
This was referenced Jun 19, 2024
Open
jtschuster
approved these changes
Jun 26, 2024
jtschuster
left a comment
jtschuster
left a comment
Member
There was a problem hiding this comment.
Not familiar with the CFG area, but LGTM.
jkurdek
approved these changes
Jun 26, 2024
Add comment about ConditionKind
This was referenced Jun 26, 2024
Build failure: Static graph-based restore failed with exit code .* but did not log an error.
#103526
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
IControlFlowGraph was modeled after the Roslyn CFG API, where a block can have at most two successors - a fall-through successor, and a conditional successor. Switch statements are represented as a chain of checks for one case at a time.
This doesn't generalize well to CFGs in IL which can have more than two branch targets for a switch instruction. This changes the interface to expose an IEnumerable of successors.