Arm64/SVE: Implemented `RoundAwayFromZero`, `RoundToNearest`, `RouteToNegativeInfininty`, `RoundToPositiveInfinity`, `RoundToZero` by ebepho · Pull Request #103588 · dotnet/runtime

ebepho · 2024-06-17T16:50:31Z

Contributes to #99957

Stress test output:

Passed test: _Sve_r::JIT.HardwareIntrinsics.Arm._Sve.Program.Sve_RoundAwayFromZero_float() : 16
Passed test: _Sve_r::JIT.HardwareIntrinsics.Arm._Sve.Program.Sve_RoundAwayFromZero_double() : 16
Passed test: _Sve_r::JIT.HardwareIntrinsics.Arm._Sve.Program.Sve_RoundToNearest_float() : 16
Passed test: _Sve_r::JIT.HardwareIntrinsics.Arm._Sve.Program.Sve_RoundToNearest_double() : 16
Passed test: _Sve_r::JIT.HardwareIntrinsics.Arm._Sve.Program.Sve_RoundToNegativeInfinity_float() : 16
Passed test: _Sve_r::JIT.HardwareIntrinsics.Arm._Sve.Program.Sve_RoundToNegativeInfinity_double() : 16
Passed test: _Sve_r::JIT.HardwareIntrinsics.Arm._Sve.Program.Sve_RoundToPositiveInfinity_float() : 16
Passed test: _Sve_r::JIT.HardwareIntrinsics.Arm._Sve.Program.Sve_RoundToPositiveInfinity_double() : 16
Passed test: _Sve_r::JIT.HardwareIntrinsics.Arm._Sve.Program.Sve_RoundToZero_float() : 16
Passed test: _Sve_r::JIT.HardwareIntrinsics.Arm._Sve.Program.Sve_RoundToZero_double() : 16
===================Running jitstress===================
------------------- {'JitMinOpts': '1'} -------------------
------------------- {'JitStress': '1'} -------------------
------------------- {'JitStress': '2'} -------------------
------------------- {'JitStress': '1', 'TieredCompilation': '1'} -------------------
------------------- {'JitStress': '2', 'TieredCompilation': '1'} -------------------
------------------- {'TailcallStress': '1'} -------------------
------------------- {'ReadyToRun': '0'} -------------------
===================Running jitstressregs===================
------------------- {'JitStressRegs': '1'} -------------------
------------------- {'JitStressRegs': '2'} -------------------
------------------- {'JitStressRegs': '3'} -------------------
------------------- {'JitStressRegs': '4'} -------------------
------------------- {'JitStressRegs': '8'} -------------------
------------------- {'JitStressRegs': '0x10'} -------------------
------------------- {'JitStressRegs': '0x80'} -------------------
------------------- {'JitStressRegs': '0x1000'} -------------------
------------------- {'JitStressRegs': '0x2000'} -------------------
===================Running jitstress2-jitstressregs===================
------------------- {'JitStress': '2', 'JitStressRegs': '1'} -------------------
------------------- {'JitStress': '2', 'JitStressRegs': '2'} -------------------
------------------- {'JitStress': '2', 'JitStressRegs': '3'} -------------------
------------------- {'JitStress': '2', 'JitStressRegs': '4'} -------------------
------------------- {'JitStress': '2', 'JitStressRegs': '8'} -------------------
------------------- {'JitStress': '2', 'JitStressRegs': '0x10'} -------------------
------------------- {'JitStress': '2', 'JitStressRegs': '0x80'} -------------------
------------------- {'JitStress': '2', 'JitStressRegs': '0x1000'} -------------------
------------------- {'JitStress': '2', 'JitStressRegs': '0x2000'} -------------------


Passed test: _Sve_ro::JIT.HardwareIntrinsics.Arm._Sve.Program.Sve_RoundAwayFromZero_float() : 16
Passed test: _Sve_ro::JIT.HardwareIntrinsics.Arm._Sve.Program.Sve_RoundAwayFromZero_double() : 16
Passed test: _Sve_ro::JIT.HardwareIntrinsics.Arm._Sve.Program.Sve_RoundToNearest_float() : 16
Passed test: _Sve_ro::JIT.HardwareIntrinsics.Arm._Sve.Program.Sve_RoundToNearest_double() : 16
Passed test: _Sve_ro::JIT.HardwareIntrinsics.Arm._Sve.Program.Sve_RoundToNegativeInfinity_float() : 16
Passed test: _Sve_ro::JIT.HardwareIntrinsics.Arm._Sve.Program.Sve_RoundToNegativeInfinity_double() : 16
Passed test: _Sve_ro::JIT.HardwareIntrinsics.Arm._Sve.Program.Sve_RoundToPositiveInfinity_float() : 16
Passed test: _Sve_ro::JIT.HardwareIntrinsics.Arm._Sve.Program.Sve_RoundToPositiveInfinity_double() : 16
Passed test: _Sve_ro::JIT.HardwareIntrinsics.Arm._Sve.Program.Sve_RoundToZero_float() : 16
Passed test: _Sve_ro::JIT.HardwareIntrinsics.Arm._Sve.Program.Sve_RoundToZero_double() : 16
===================Running jitstress===================
------------------- {'JitMinOpts': '1'} -------------------
------------------- {'JitStress': '1'} -------------------
------------------- {'JitStress': '2'} -------------------
------------------- {'JitStress': '1', 'TieredCompilation': '1'} -------------------
------------------- {'JitStress': '2', 'TieredCompilation': '1'} -------------------
------------------- {'TailcallStress': '1'} -------------------
------------------- {'ReadyToRun': '0'} -------------------
===================Running jitstressregs===================
------------------- {'JitStressRegs': '1'} -------------------
------------------- {'JitStressRegs': '2'} -------------------
------------------- {'JitStressRegs': '3'} -------------------
------------------- {'JitStressRegs': '4'} -------------------
------------------- {'JitStressRegs': '8'} -------------------
------------------- {'JitStressRegs': '0x10'} -------------------
------------------- {'JitStressRegs': '0x80'} -------------------
------------------- {'JitStressRegs': '0x1000'} -------------------
------------------- {'JitStressRegs': '0x2000'} -------------------
===================Running jitstress2-jitstressregs===================
------------------- {'JitStress': '2', 'JitStressRegs': '1'} -------------------
------------------- {'JitStress': '2', 'JitStressRegs': '2'} -------------------
------------------- {'JitStress': '2', 'JitStressRegs': '3'} -------------------
------------------- {'JitStress': '2', 'JitStressRegs': '4'} -------------------
------------------- {'JitStress': '2', 'JitStressRegs': '8'} -------------------
------------------- {'JitStress': '2', 'JitStressRegs': '0x10'} -------------------
------------------- {'JitStress': '2', 'JitStressRegs': '0x80'} -------------------
------------------- {'JitStress': '2', 'JitStressRegs': '0x1000'} -------------------
------------------- {'JitStress': '2', 'JitStressRegs': '0x2000'} -------------------

cc @dotnet/arm64-contrib

updating branch due to assert issue.

ghost · 2024-06-17T16:50:36Z

Note regarding the new-api-needs-documentation label:

This serves as a reminder for when your PR is modifying a ref *.cs file and adding/modifying public APIs, please make sure the API implementation in the src *.cs file is documented with triple slash comments, so the PR reviewers can sign off that change.

ghost · 2024-06-17T16:50:38Z

Note regarding the new-api-needs-documentation label:

This serves as a reminder for when your PR is modifying a ref *.cs file and adding/modifying public APIs, please make sure the API implementation in the src *.cs file is documented with triple slash comments, so the PR reviewers can sign off that change.

dotnet-policy-service · 2024-06-17T16:51:00Z

Tagging subscribers to this area: @dotnet/area-system-runtime-intrinsics
See info in area-owners.md if you want to be subscribed.

kunalspathak

LGTM. Thanks!

amanasifkhalid · 2024-06-17T21:20:00Z

@ebepho did you mean to merge this?

ebepho · 2024-06-17T21:42:35Z

@ebepho did you mean to merge this?

Just wanted to double check that I had ran the tests for Sve_ro before anyone merges it. I'm ready to merge now.

amanasifkhalid · 2024-06-18T17:18:49Z

/ba-g Known error #103642 now fixed

ebepho and others added 17 commits June 5, 2024 14:30

Added ConverToInt32 and ConvertToUInt32 for float inputs.

c738b77

Added flags to handle only low predicate registers.

35d39d9

Fixed merge conflicts.

7a781e1

Fix whitespace

1378d60

Remove special codegen flag

10c7a15

Added new test template for operations with different return types.

8004868

Merge branch 'main' into ConvertToInt32

af7ccd4

updating branch due to assert issue.

Add new test template.

8cb76da

Added api for ConvertToInt32 and ConvertToUInt 32 for double.

abe25fc

fix merge conflicts.

0f51f38

Merge branch 'dotnet:main' into main

7fabb91

Merge branch 'main' of github.com:ebepho/runtime

d5374ca

Merge branch 'main' of github.com:ebepho/runtime

4aa224d

Round SVE intrinsics for floats.

49a6c85

Completed Round SVE fp apis.

bd2702d

Merge branch 'main' of github.com:ebepho/runtime

56601b4

Merge branch 'main' into round

6ba83c3

ghost added area-System.Runtime.Intrinsics new-api-needs-documentation labels Jun 17, 2024

dotnet-policy-service Bot assigned ebepho Jun 17, 2024

ebepho changed the title ~~Round~~ Arm64/SVE: Implement RoundAwayFromZero, RoundToNearest, RouteToNegativeInfininty, RoundToPositiveInfinity, RoundToZero Jun 17, 2024

ebepho added the arm-sve Work related to arm64 SVE/SVE2 support label Jun 17, 2024

ebepho changed the title ~~Arm64/SVE: Implement RoundAwayFromZero, RoundToNearest, RouteToNegativeInfininty, RoundToPositiveInfinity, RoundToZero~~ Arm64/SVE: Implemented RoundAwayFromZero, RoundToNearest, RouteToNegativeInfininty, RoundToPositiveInfinity, RoundToZero Jun 17, 2024

amanasifkhalid requested a review from kunalspathak June 17, 2024 17:59

kunalspathak mentioned this pull request Jun 17, 2024

Arm64: Implement SVE APIs #99957

Closed

kunalspathak approved these changes Jun 17, 2024

View reviewed changes

build-analysis Bot mentioned this pull request Jun 17, 2024

SslStreamTlsResumeTests.ClientDisableTlsResume_Succeeds failed in CI #103449

Closed

build-analysis Bot mentioned this pull request Jun 17, 2024

FileSystemWatcher_InternalBufferSize_SynchronizingObject test failed in CI #103495

Closed

ebepho closed this Jun 17, 2024

ebepho reopened this Jun 17, 2024

ebepho merged commit b93061a into dotnet:main Jun 18, 2024

github-actions Bot locked and limited conversation to collaborators Jul 19, 2024

Navigation Menu

Uh oh!

Arm64/SVE: Implemented `RoundAwayFromZero`, `RoundToNearest`, `RouteToNegativeInfininty`, `RoundToPositiveInfinity`, `RoundToZero` - #103588

Arm64/SVE: Implemented `RoundAwayFromZero`, `RoundToNearest`, `RouteToNegativeInfininty`, `RoundToPositiveInfinity`, `RoundToZero` #103588
ebepho merged 17 commits into
dotnet:mainfrom
ebepho:round

ebepho commented Jun 17, 2024 •

edited

Loading

Uh oh!

ghost commented Jun 17, 2024

Uh oh!

ghost commented Jun 17, 2024

Uh oh!

dotnet-policy-service Bot commented Jun 17, 2024

Uh oh!

kunalspathak left a comment

Uh oh!

amanasifkhalid commented Jun 17, 2024

Uh oh!

ebepho commented Jun 17, 2024

Uh oh!

amanasifkhalid commented Jun 18, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Uh oh!

Conversation

ebepho commented Jun 17, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

ghost commented Jun 17, 2024

Uh oh!

ghost commented Jun 17, 2024

Uh oh!

dotnet-policy-service Bot commented Jun 17, 2024

Uh oh!

kunalspathak left a comment

Choose a reason for hiding this comment

Uh oh!

amanasifkhalid commented Jun 17, 2024

Uh oh!

ebepho commented Jun 17, 2024

Uh oh!

amanasifkhalid commented Jun 18, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

ebepho commented Jun 17, 2024 •

edited

Loading