JIT: Added Sve.LoadVectorNonTemporal/NonFaulting/128AndReplicateToVector APIs#103392
JIT: Added Sve.LoadVectorNonTemporal/NonFaulting/128AndReplicateToVector APIs#103392kunalspathak merged 2 commits intodotnet:mainfrom
Sve.LoadVectorNonTemporal/NonFaulting/128AndReplicateToVector APIs#103392Conversation
|
Note regarding the |
1 similar comment
|
Note regarding the |
|
Tagging subscribers to this area: @dotnet/area-system-runtime-intrinsics |
|
@dotnet/arm64-contrib @kunalspathak this is ready. The test results do have failures for NonTemporal and 128AndReplicateToVector because of predicate register support. |
| @@ -0,0 +1,270 @@ | |||
| // Licensed to the .NET Foundation under one or more agreements. | |||
There was a problem hiding this comment.
I think this file is doing the same job as SveLoadMaskedUnOpTest.template, which is being used for
Vector<byte> LoadVector(Vector<byte> mask, byte* address) etc.
Your new file is better. Can you combine them both into a single template? (either naming is fine)
There was a problem hiding this comment.
Originally I wanted this, but it's a bit more difficult because the other Load APIs take different operand types. Can we do that one in another PR?
kunalspathak
left a comment
There was a problem hiding this comment.
Overall looks great. Added few questions and comments about test.
src/libraries/System.Runtime.Intrinsics/ref/System.Runtime.Intrinsics.cs
Show resolved
Hide resolved
| @@ -0,0 +1,270 @@ | |||
| // Licensed to the .NET Foundation under one or more agreements. | |||
Contributes to #99957
Adds: