Skip to content

Dispose IDisposables in RegexGenerator #103142

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 13, 2024
Merged

Dispose IDisposables in RegexGenerator #103142

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ca1de71
Dispose IDisposables in RegexGenerator
omajid Jun 6, 2024
428f7e5
Update src/libraries/System.Text.RegularExpressions/gen/RegexGenerato…
buyaa-n Jun 12, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/libraries/System.Text.RegularExpressions/gen/RegexGenerator.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -140,8 +140,8 @@ public void Initialize(IncrementalGeneratorInitializationContext context)
}

// At this point we'll be emitting code. Create a writer to hold it all.
var sw = new StringWriter();
IndentedTextWriter writer = new(sw);
using StringWriter sw = new();
using IndentedTextWriter writer = new(sw);

// Add file headers and required usings.
foreach (string header in s_headers)
Expand Down