Skip to content

Socket.DontFragment can't be set on IPv6 DualMode sockets #102700

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
May 29, 2024
Merged

Socket.DontFragment can't be set on IPv6 DualMode sockets #102700

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
2081c0a
Socket.DontFragment can't be set on IPv6 DualMode sockets
pedrobsaila May 26, 2024
8dc4566
dont fragment do not work on osx
pedrobsaila May 26, 2024
4ab1219
mention why test is not run for OSX
pedrobsaila May 27, 2024
caeff88
Merge remote-tracking branch 'upstream/main' into 76410
pedrobsaila May 28, 2024
f7bf1ae
make tests execute on windows and linux only
pedrobsaila May 28, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/libraries/System.Net.Sockets/src/System/Net/Sockets/Socket.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -636,7 +636,7 @@ public bool DontFragment
{
get
{
if (_addressFamily == AddressFamily.InterNetwork)
if (_addressFamily == AddressFamily.InterNetwork || (_addressFamily == AddressFamily.InterNetworkV6 && DualMode))
{
return (int)GetSocketOption(SocketOptionLevel.IP, SocketOptionName.DontFragment)! != 0 ? true : false;
}
Expand All @@ -648,7 +648,7 @@ public bool DontFragment

set
{
if (_addressFamily == AddressFamily.InterNetwork)
if (_addressFamily == AddressFamily.InterNetwork || (_addressFamily == AddressFamily.InterNetworkV6 && DualMode))
{
SetSocketOption(SocketOptionLevel.IP, SocketOptionName.DontFragment, value ? 1 : 0);
}
Expand Down
11 changes: 11 additions & 0 deletions src/libraries/System.Net.Sockets/tests/FunctionalTests/ArgumentValidationTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1157,5 +1157,16 @@ public void CancelConnectAsync_NullEventArgs_Throws_ArgumentNull()
{
Assert.Throws<ArgumentNullException>(() => Socket.CancelConnectAsync(null));
}

// MacOS And FreeBSD do not support setting don't-fragment (DF) bit on dual mode socket
[Fact]
[PlatformSpecific(TestPlatforms.Linux | TestPlatforms.Windows)]
public void CanSetDontFragment_OnIPV6Address_DualModeSocket()
{
using Socket socket = new Socket(AddressFamily.InterNetworkV6, SocketType.Dgram, ProtocolType.Udp);
socket.DualMode = true;
socket.DontFragment = true;
Assert.True(socket.DontFragment);
}
}
}