Skip to content

Handle more than 64 registers - Part 3 #102474

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
kunalspathak wants to merge 23 commits into from
Closed

Handle more than 64 registers - Part 3 #102474

kunalspathak wants to merge 23 commits into from

Conversation

@kunalspathak
Copy link
Contributor

@kunalspathak kunalspathak commented May 21, 2024 •
edited
Loading

Has changes from #102469 and some work arounds until #102297 goes in. I will remove them from this PR once they are merged.

  • This PR basically adds a high field in regMaskTP, but do not use it.
  • Introduce a new type SingleTypeRegSet that denotes a 8-byte register set to represent registers from a single type i.e. gpr or float and in future predicated registers.
  • Updated various places in LSRA that handles transition from regMaskTP and SingleTypeRegSet. Basically, all the fields in RefPosition, Interval, RegisterSelection are updated to be SingleTypeRegSet because they can never have mixed register set.

kunalspathak added 20 commits May 14, 2024 22:13
@kunalspathak
Add high in regMaskTP
cec9ad9
@kunalspathak
Introduce SingleTypeRegSet
5fa863e
@kunalspathak
Use SingleTypeRegSet in few places
7dba61b
@kunalspathak
Delete some methods in regMaskTP
f68cf05
@kunalspathak
Delete some more methods of regMaskTP
7f8a9b6
@kunalspathak
Fix actualRegistersMask
2ede666
@kunalspathak
Use SingleTypeRegSet in consecutive register code
4b873d4
@kunalspathak
Use SingleTypeRegSet in consecutive registers codebase
98caccf
@kunalspathak
Change genRegMask*() method to return SingleTypeRegSet
dbb72eb
@kunalspathak
wip
36d5919
@kunalspathak
another wip
a647a65
@kunalspathak
Everything except newRefPosition/killMask
9a15670
@kunalspathak
refactor code around buildkill
5e739a4
@kunalspathak
fix build errors
e93f528
@kunalspathak
some more errors
05b09b2
@kunalspathak
jit format
f00f7a8
@kunalspathak
Merge remote-tracking branch 'kp/lsra-refactor' into more-than-64-par…
d356c89 
…t2-kill
@kunalspathak
fixed build error for arm64
06bd9e2
@kunalspathak
REVERT: temporary add #ifdef TARGET_ARM64 for accessing regMaskTP met…
325bc6e 
…hods
@kunalspathak
Merge remote-tracking branch 'origin/main' into more-than-64-part2-kill
92378d5
@ghost ghost added the area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI label May 21, 2024
@kunalspathak kunalspathak changed the title More than 64 part2 kill Handle more than 64 registers - Part 3 May 21, 2024
@kunalspathak
Copy link
Contributor Author

kunalspathak commented May 23, 2024

replaced by #102592

@github-actions github-actions bot locked and limited conversation to collaborators Jun 22, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

No reviews

Assignees

@kunalspathak kunalspathak

Labels

area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@kunalspathak