[release/8.0] Fix data race leading to a deadlock when opening QuicStream#102147
Merged
rzikm merged 2 commits intodotnet:release/8.0-stagingfrom May 13, 2024
Merged
[release/8.0] Fix data race leading to a deadlock when opening QuicStream#102147rzikm merged 2 commits intodotnet:release/8.0-stagingfrom
rzikm merged 2 commits intodotnet:release/8.0-stagingfrom
Conversation
…01250) * Fix data race leading to a deadlock. * Remove unwanted change * Code review feedback * Fix hang * Add assert * Fix potential crash * Code review feedback
ghost
added
the
Contributor
|
Tagging subscribers to this area: @dotnet/ncl |
This was referenced May 13, 2024
Closed
karelz
approved these changes
May 13, 2024
Member
karelz
left a comment
karelz
left a comment
There was a problem hiding this comment.
Rare deadlock prevention - worth backporting.
Member
Author
|
email sent to shiproom for approval. |
CarnaViire
approved these changes
May 13, 2024
rzikm
added
Servicing-approved
Member
Author
|
Approved via email |
Member
Author
|
No CI failures. Good to merge |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of #101250
Fixes #101233.
Fixes #100971.
Contributes to #101463
Customer Impact
Customers may encounter a deadlock when attempting to open an outbound QuicStream and the peer closes the connection at the same time.
Regression
No
Testing
Functional tests as part of CI.
Deadlock scenario tested locally by modifying the timing of the operations to make the deadlock more likely.
Risk
Low, issue is well understood and fix affects only code path for opening an outbound QuicStream, which is covered extensively by functional tests.