Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[LoongArch64] Simplify flags for passing struct in registers. #102041

Merged
merged 1 commit into from
May 9, 2024
Merged

[LoongArch64] Simplify flags for passing struct in registers. #102041

merged 1 commit into from
May 9, 2024

Conversation

LuckyXu-HF
Copy link
Contributor

@LuckyXu-HF LuckyXu-HF commented May 9, 2024 •
edited
Loading

[LoongArch64] Simplify flags for passing struct in registers.

@LuckyXu-HF
[LoongArch64] Simplify flags for passing struct in registers.
43c9c52 
Change-Id: Idbe644c0bc5baeb53a53e16731824e28aacf67a0
@dotnet-policy-service dotnet-policy-service bot added the community-contribution Indicates that the PR has been added by a community member label May 9, 2024
@LuckyXu-HF
Copy link
Contributor Author

This is similar to PR #100080

@tomeksowi , great simplification!
To reuse the duplicate codes I modified a littile bit positon of TARGET_RISCV64 in methodtable.cpp.
@tomeksowi , @clamp03 Could you please take a look?

@LuckyXu-HF
Copy link
Contributor Author

@shushanhf @jkotas Could you please review this PR? Thanks.

@build-analysis build-analysis bot mentioned this pull request May 9, 2024
Closed
shushanhf
shushanhf approved these changes May 9, 2024
View reviewed changes
Copy link
Contributor

@shushanhf shushanhf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

jkotas
jkotas approved these changes May 9, 2024
View reviewed changes
Copy link
Member

@jkotas jkotas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@jkotas jkotas merged commit 02e348b into dotnet:main May 9, 2024
87 of 89 checks passed
@LuckyXu-HF LuckyXu-HF deleted the main-LA64 branch May 10, 2024 00:59
Ruihan-Yin pushed a commit to Ruihan-Yin/runtime that referenced this pull request May 30, 2024
@LuckyXu-HF @Ruihan-Yin
[LoongArch64] Simplify flags for passing struct in registers. (dotnet…
106183a 
…#102041)

Change-Id: Idbe644c0bc5baeb53a53e16731824e28aacf67a0
@github-actions github-actions bot locked and limited conversation to collaborators Jun 9, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@tomeksowi tomeksowi tomeksowi approved these changes

@jkotas jkotas jkotas approved these changes

@shushanhf shushanhf shushanhf approved these changes

@MichalStrehovsky MichalStrehovsky Awaiting requested review from MichalStrehovsky MichalStrehovsky is a code owner

Assignees
No one assigned
Labels
arch-loongarch64 area-VM-coreclr community-contribution Indicates that the PR has been added by a community member
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@LuckyXu-HF @tomeksowi @jkotas @shushanhf