Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add the auto-created .mono/ folder to .gitignore #101954

Closed
wants to merge 1 commit into from

Conversation

carlossanlop
Copy link
Member

I noticed we don't have a .mono/ folder commited at the root of the repo, but it gets created sometimes when working with native code. I'm adding the entry to .gitignore ensures we don't accidentally get it included in a PR in the future.

Copy link
Contributor

Tagging subscribers to this area: @directhex
See info in area-owners.md if you want to be subscribed.

@carlossanlop
Copy link
Member Author

Looks like the CI is breaking, but I'm not yet sure if it's due to my change.

@carlossanlop
Copy link
Member Author

I don't have a consistent repro to get the .mono/ folder created at the top level. Since this seems suspiciously related to the CI break, I'll close the PR and if I can get a consistent repro, I'll investigate why the folder is showing up.

@carlossanlop carlossanlop deleted the GitIgnoreMono branch May 7, 2024 01:26
@jkoritzinsky
Copy link
Member

I think the CI break is unrelated to this PR. I think it's related to my docker image changes (revert PR already open for that)

@carlossanlop
Copy link
Member Author

Ah, okay, thanks for checking! I'll reopen after you merge your PR.

@jkoritzinsky
Copy link
Member

Can you approve the revert if you have a chance?

dotnet/dotnet-buildtools-prereqs-docker#1038

@carlossanlop
Copy link
Member Author

Done!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants