Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[mono] Fix LLVMArgWasmVtypeAsScalar when a method doesn't set its return value #101299

Merged
merged 8 commits into from
Apr 25, 2024
Merged

[mono] Fix LLVMArgWasmVtypeAsScalar when a method doesn't set its return value #101299

merged 8 commits into from
Apr 25, 2024

Commits on Apr 19, 2024

  1. Fix an assertion when a method doesn't set its return value

    @kotlarmilos
    kotlarmilos committed Apr 19, 2024
    Configuration menu
    Copy the full SHA
    b219060 View commit details
    Browse the repository at this point in the history

Commits on Apr 22, 2024

  1. Test LLVMBuildRet ins for LLVMArgWasmVtypeAsScalar when lhs is null

    @kotlarmilos
    kotlarmilos committed Apr 22, 2024
    Configuration menu
    Copy the full SHA
    f826d1b View commit details
    Browse the repository at this point in the history

  2. Update mini-llvm.c 

    I think we should handle it here, the same way as `LLVMArgVtypeAsScalar`. They differ only in the return type, where the wasm specific one is returning type of the element instead of `int`.
    @radekdoulik
    radekdoulik authored Apr 22, 2024
    Configuration menu
    Copy the full SHA
    d5c6eec View commit details
    Browse the repository at this point in the history

  3. Revert changes

    @kotlarmilos
    kotlarmilos committed Apr 22, 2024
    Configuration menu
    Copy the full SHA
    b066b41 View commit details
    Browse the repository at this point in the history

  4. Include TrimmerRootDescriptor only on Apple mobile platforms

    @kotlarmilos
    kotlarmilos committed Apr 22, 2024
    Configuration menu
    Copy the full SHA
    81fd3d9 View commit details
    Browse the repository at this point in the history

Commits on Apr 23, 2024

  1. Update src/mono/mono/mini/mini-llvm.c 

    Co-authored-by: Aleksey Kliger (λgeek) <akliger@gmail.com>
    @kotlarmilos @lambdageek
    kotlarmilos and lambdageek authored Apr 23, 2024
    Configuration menu
    Copy the full SHA
    c8e9fd0 View commit details
    Browse the repository at this point in the history

  2. Fix formatting in mini-llvm.c

    @kotlarmilos
    kotlarmilos committed Apr 23, 2024
    Configuration menu
    Copy the full SHA
    f04d56f View commit details
    Browse the repository at this point in the history

  3. Update System.Reflection.MetadataLoadContext.Tests.csproj to conditio… 

    …nally include TrimmerRootDescriptor on Apple mobile platforms
    @kotlarmilos
    kotlarmilos committed Apr 23, 2024
    Configuration menu
    Copy the full SHA
    6214907 View commit details
    Browse the repository at this point in the history