Skip to content

Disable nogcregion #100167

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Mar 23, 2024
Merged

Disable nogcregion #100167

merged 2 commits into from
Mar 23, 2024

Conversation

mangod9
Copy link
Member

@mangod9 mangod9 commented Mar 22, 2024 •
edited
Loading

Disabling a test which is asserting, most likely due to a compiler issue. But disabling since we continue to investigate.

@ghost ghost added the area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI label Mar 22, 2024
@dotnet-policy-service Dotnet Policy Service
Copy link
Contributor

Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch
See info in area-owners.md if you want to be subscribed.

@markples markples mentioned this pull request Mar 23, 2024
Closed
markples
markples approved these changes Mar 23, 2024
View reviewed changes
Copy link
Contributor

@markples markples left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All OS/Arch/Runtime is probably too much, but unblocking is more important than being precise right now.

@mangod9 mangod9 merged commit b31f952 into dotnet:main Mar 23, 2024
@BruceForstall
Copy link
Contributor

Thank you!

markples added a commit to markples/runtime that referenced this pull request Mar 26, 2024
@markples
Revert "Disable nogcregion (dotnet#100167)"
b83a78f 
This reverts commit b31f952.
@github-actions github-actions bot locked and limited conversation to collaborators Apr 23, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Maoni0 Maoni0 Maoni0 approved these changes

@markples markples markples approved these changes

@cshung cshung Awaiting requested review from cshung

@BruceForstall BruceForstall Awaiting requested review from BruceForstall

Assignees

@mangod9 mangod9

Labels
area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@mangod9 @BruceForstall @Maoni0 @markples