Fix RhpLockCmpXchg64 FCall on win-x86 #100155
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
|
Tagging subscribers to this area: @agocke, @MichalStrehovsky, @jkotas |
dotnet-policy-service
bot
added
the
community-contribution
This was referenced Mar 22, 2024
|
/ba-g Infrastructure timeout (#76454). The affected leg does not exercise the change in meaningful way, no reason for retrying. |
jkotas
approved these changes
Mar 22, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I broke win-x86 builds with PR #100021 when
RhpLockCmpXchg64was moved to C code. On x86 we need to properly name mangle it and reverse the parameter order.