[mono] [net7] Stop exporting ICU symbols from Mono #100063
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
|
Tagging subscribers to this area: @directhex |
matouskozak
added
area-System.Globalization
runtime-mono
matouskozak
added
the
NO-MERGE
matouskozak
requested review from
vargaz,
lambdageek and
SamMonoRT
as code owners
rolfbjarne
approved these changes
Mar 21, 2024
jeffschwMSFT
removed
the
Servicing-consider
matouskozak
removed
the
NO-MERGE
jeffschwMSFT
added
the
Servicing-consider
|
/azp run runtime-extra-platforms |
|
Azure Pipelines successfully started running 1 pipeline(s). |
This was referenced Mar 25, 2024
This was referenced Mar 25, 2024
rbhanda
added
Servicing-rejected
and removed
Servicing-consider
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This is a .NET 7 version of #99449 fix for #98941.
Customer Impact
When running against the latest XCode, the iOS 17.4 simulator causes our apps to crash due to a symbols clash between their version of ICU and our version. Prior to this change, by default we had been exporting all our symbols and been lucky due to the ICU versions matching. To fix, we hide our symbols via
-hidden-lxso that there is no longer a clash.NOTE 1: There is no known workaround for .NET 7 at the moment. The .NET 8 workaround to link Mono statically from #98941 doesn't work. (cc @rolfbjarne)
NOTE 2: This does not impact .NET 9 as we have moved away from shipping our own version of ICU on iOS.
Regression
Testing
We verified the fix thru manually copying new version of
libmonosgen-2.0.dylibinto local version of dotnet (/usr/local/share/dotnet/packs/Microsoft.NETCore.App.Runtime.Mono.iossimulator-arm64/7.0.17/runtimes/iossimulator-arm64/native) and re-building the crashing app. Currently, we are unable to verify this E2E by using a template iOS app with custom runtime due to issues with trampolines.Risk
Low, but since we were unable to verify E2E with a template app, there may be more churn required if the iOS SDK team finds any issues.
Contributed: @ivanpovazan
fyi: @vitek-karas @akoeplinger @steveisok @dalexsoto @mkhamoyan @rolfbjarne